skip postfix node when resolving distinct type from impl AST #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`resolveTypeFromDistinct` calls `getImpl` on the distinct type which yields an `nkTypeDef` node of the original distinct type declaration, and returns the first child of the node, what would normally be the type name. Normally when a type is exported its name in the AST becomes an `nkPostfix` node, however due to a [Nim bug](nim-lang/Nim#22933) this node was not saved in typed AST and the first child was always the type symbol node. If the bug in Nim is fixed, `resolveTypeFromDistinct` has to skip the postfix node here.
This was referenced Dec 18, 2023
|
Sorry for the delay! Should be less busy and more attentive again. I had no idea either that was a bug. Cool and thanks for the fix! |
Araq
pushed a commit
to nim-lang/Nim
that referenced
this pull request
Dec 23, 2023
Continued from #23096 which was reverted due to breaking a package and failing docgen tests. Docgen should now work, but ~~a PR is still pending for the package: SciNim/Unchained#45 has been merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolveTypeFromDistinctcallsgetImplon the distinct type which yields annkTypeDefnode of the original distinct type declaration, and returns the first child of the node, what would normally be the type name.Normally when a type is exported its name in the AST becomes an
nkPostfixnode, however due to a Nim bug this node was not saved in typed AST and the first child was always the type symbol node. If the bug in Nim is fixed,resolveTypeFromDistincthas to skip the postfix node here.