Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cantilever.jmd #919

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Create cantilever.jmd #919

wants to merge 12 commits into from

Conversation

Spinachboul
Copy link
Contributor

Add a new surrogates benchmark!

@ChrisRackauckas
Copy link
Member

The manifest is all messed up, it seems like it was mixed with another? https://buildkite.com/julialang/scimlbenchmarks-dot-jl/builds/2284#018ed813-4107-4ee4-bebc-bc6094734f48/369-378

Comment on lines 6 to 8
DiffEqPhysics = "055956cb-9e8b-5191-98cc-73ae4a59e68a"
DiffEqProblemLibrary = "a077e3f3-b75c-5d7f-a0c6-6bc4c8ec64a9"
DifferentialEquations = "0c46a032-eb83-5123-abaf-570d42b7fbaa"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

@Spinachboul
Copy link
Contributor Author

Spinachboul commented Apr 13, 2024

Actually I reproduced the Manifest.toml again for the new benchmark, and overwrote it over the existing one!

@Spinachboul
Copy link
Contributor Author

Will fix it

Copy link
Member

@sathvikbhagavan sathvikbhagavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you post the results?

author: Mridul Jain, Chris Rackauckas
---

The Cantilever Beam function is defined as:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this function exactly? I understand its related to Cantilever Beam but what does it compute?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the best of my knowledge, engineers need numerical solvers for computational analysis and simulations which are precisely performed on cantilever beams.

## Fitting the surrogate models

```julia
mypoly_surrogate = PolynomialChaosSurrogate(xys, zs, lb, ub)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks incorrect. Shouldn't it be x_train, y_train instead of xys, zs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, will just replace it after testing once

benchmarks/Surrogates/cantilever.jmd Outdated Show resolved Hide resolved

```julia
# Plot for Polynomial Surrogate
p1 = surface(x, y, (x, y) -> mypoly_surrogate([x y]))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make more sense to plot the surface of the original function and scatter the surrogate predictions instead of surface plot of the surrogate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Are these scatter plots fine for the model??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the plots for all the models, plotting surface for the canti lever and scatter for the surrogates
@ChrisRackauckas and @sathvikbhagavan

benchmarks/Surrogates/cantilever.jmd Outdated Show resolved Hide resolved
benchmarks/Surrogates/cantilever.jmd Outdated Show resolved Hide resolved
Spinachboul and others added 5 commits April 15, 2024 21:54
Co-authored-by: Sathvik Bhagavan <35105271+sathvikbhagavan@users.noreply.github.com>
Co-authored-by: Sathvik Bhagavan <35105271+sathvikbhagavan@users.noreply.github.com>
Co-authored-by: Sathvik Bhagavan <35105271+sathvikbhagavan@users.noreply.github.com>
@ChrisRackauckas
Copy link
Member

Please fix the errors before adding more things so something can merge.

@Spinachboul
Copy link
Contributor Author

Got it!
I apologise and won't repeat this in future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants