-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create cantilever.jmd #919
base: master
Are you sure you want to change the base?
Conversation
The manifest is all messed up, it seems like it was mixed with another? https://buildkite.com/julialang/scimlbenchmarks-dot-jl/builds/2284#018ed813-4107-4ee4-bebc-bc6094734f48/369-378 |
benchmarks/Surrogates/Project.toml
Outdated
DiffEqPhysics = "055956cb-9e8b-5191-98cc-73ae4a59e68a" | ||
DiffEqProblemLibrary = "a077e3f3-b75c-5d7f-a0c6-6bc4c8ec64a9" | ||
DifferentialEquations = "0c46a032-eb83-5123-abaf-570d42b7fbaa" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
Actually I reproduced the Manifest.toml again for the new benchmark, and overwrote it over the existing one! |
Will fix it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you post the results?
author: Mridul Jain, Chris Rackauckas | ||
--- | ||
|
||
The Cantilever Beam function is defined as: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this function exactly? I understand its related to Cantilever Beam but what does it compute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To the best of my knowledge, engineers need numerical solvers for computational analysis and simulations which are precisely performed on cantilever beams.
benchmarks/Surrogates/cantilever.jmd
Outdated
## Fitting the surrogate models | ||
|
||
```julia | ||
mypoly_surrogate = PolynomialChaosSurrogate(xys, zs, lb, ub) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks incorrect. Shouldn't it be x_train
, y_train
instead of xys
, zs
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, will just replace it after testing once
benchmarks/Surrogates/cantilever.jmd
Outdated
|
||
```julia | ||
# Plot for Polynomial Surrogate | ||
p1 = surface(x, y, (x, y) -> mypoly_surrogate([x y])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make more sense to plot the surface of the original function and scatter the surrogate predictions instead of surface plot of the surrogate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the plots for all the models, plotting surface for the canti lever and scatter for the surrogates
@ChrisRackauckas and @sathvikbhagavan
Co-authored-by: Sathvik Bhagavan <35105271+sathvikbhagavan@users.noreply.github.com>
Co-authored-by: Sathvik Bhagavan <35105271+sathvikbhagavan@users.noreply.github.com>
Co-authored-by: Sathvik Bhagavan <35105271+sathvikbhagavan@users.noreply.github.com>
Please fix the errors before adding more things so something can merge. |
Got it! |
Add a new surrogates benchmark!