-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add discrete saving functionality #1019
Conversation
1b090e7
to
4826b3c
Compare
@@ -611,6 +613,9 @@ end | |||
end | |||
integrator.u_modified = true | |||
callback.affect!(integrator) | |||
|
|||
SciMLBase.save_discrete_parameters_after_callback( | |||
integrator.sol, parameter_values(integrator), current_time(integrator)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it would interpolate separately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interpolation is independent of this. I haven't gotten around to it yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interpolation is implemented in SciML/SciMLBase.jl#645
4826b3c
to
dd8a670
Compare
Requires SciML/SciMLBase.jl#645 |
This PR is not necessary anymore |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.