Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match the behavior of /cypher/execute to /dynamic/ #288

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tgbugs
Copy link
Collaborator

@tgbugs tgbugs commented Mar 8, 2021

This change makes it vastly simpler to develop dynamic cypher queries
by changing the /cypher/execute endpoint to match the preprocessing
and return types for /dynamic/ cypher queries.

Related to #287. @dbrnz

This change makes it vastly simpler to develop dynamic cypher queries
by changing the /cypher/execute endpoint to match the preprocessing
and return types for /dynamic/ cypher queries.
@dbrnz
Copy link

dbrnz commented Mar 8, 2021

Thanks @tgbugs, this is exactly what I'm after! 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling cb0c561 on SciCrunch:cypher-execute-fix into 2b1198e on SciGraph:master.

this change brings the execute endpoint to feature parity with the
dynamic endpoint so it is possible to develop parameterized queries
using the execute endpoint and deploy them unchanged to the dynamic
endpoint
maven-jar-plugin 2.5 silently fails to create the Class-Path entry in
MANIFEST.MF when building with maven 3.8.3 (2.5 works with 3.8.1) as far
as I can tell there are no issues upgrading to use 3.2.0

when trying to run scigraph services built with a newer version of maven
the result is that jave cannot find the Main-Class so the jar cannot run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants