Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, fix incompatibility with Deno #98

Merged
merged 4 commits into from Nov 28, 2023
Merged

Update dependencies, fix incompatibility with Deno #98

merged 4 commits into from Nov 28, 2023

Conversation

shepherdjerred
Copy link
Contributor

@shepherdjerred shepherdjerred commented Nov 25, 2023

Hi!

This PR updates all of the project's dependencies to the latest versions. I ran npx npm-check-updates -u to update NPM dependencies. This resolves a medium security vulnerability in Axios.

ts-lint has been deprecated for a few years, so I replaced it with a comparable eslint configuration. I had to make a few small tweaks to the code to get the linter to pass. I also updated the GHA workflows to use Node JS 20.x, since that is the latest LTS.

I tried to update the yarn.lock and bun.lock files. I've never used either, so I'm not sure if I did that right.

To verify my changes I ran:

npm run build
npm run lint
npm run test

Please let me know if I missed anything, or if you'd like any changes made.

fixes an imcompatibility with Deno: #97
@shepherdjerred
Copy link
Contributor Author

Hi @Sansossio, please let me know how this look to you!

@Sansossio
Copy link
Owner

Hey @shepherdjerred ! What a nice job! But the checks failed :( could you fix them? Also update the version in package.json so the pipeline could be able to deploy the new version when merge !

@shepherdjerred
Copy link
Contributor Author

Will do, thank you for the quick response!

@shepherdjerred
Copy link
Contributor Author

shepherdjerred commented Nov 27, 2023

I believe I fixed the issue: the commands are running correctly on my machine :)

I think that GitHub is still processing the push, though. Once https://github.com/shepherdjerred/twisted/commit/b62bf6661ddcd9e4d216662e9e0f6bfb704d77ae is in this PR it should work.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (eee376b) 83.52% compared to head (affe027) 83.61%.
Report is 45 commits behind head on master.

Files Patch % Lines
src/base/base.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   83.52%   83.61%   +0.08%     
==========================================
  Files          28       29       +1     
  Lines         601      824     +223     
  Branches       75      119      +44     
==========================================
+ Hits          502      689     +187     
- Misses         99      135      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sansossio
Copy link
Owner

@shepherdjerred update the package.json version please

@shepherdjerred
Copy link
Contributor Author

Done!

@Sansossio Sansossio merged commit aa763a3 into Sansossio:master Nov 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants