New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies, fix incompatibility with Deno #98
Conversation
fixes an imcompatibility with Deno: #97
Hi @Sansossio, please let me know how this look to you! |
Hey @shepherdjerred ! What a nice job! But the checks failed :( could you fix them? Also update the version in package.json so the pipeline could be able to deploy the new version when merge ! |
Will do, thank you for the quick response! |
I believe I fixed the issue: the commands are running correctly on my machine :) I think that GitHub is still processing the push, though. Once https://github.com/shepherdjerred/twisted/commit/b62bf6661ddcd9e4d216662e9e0f6bfb704d77ae is in this PR it should work. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 83.52% 83.61% +0.08%
==========================================
Files 28 29 +1
Lines 601 824 +223
Branches 75 119 +44
==========================================
+ Hits 502 689 +187
- Misses 99 135 +36 ☔ View full report in Codecov by Sentry. |
@shepherdjerred update the package.json version please |
Done! |
Hi!
This PR updates all of the project's dependencies to the latest versions. I ran
npx npm-check-updates -u
to update NPM dependencies. This resolves a medium security vulnerability in Axios.ts-lint has been deprecated for a few years, so I replaced it with a comparable eslint configuration. I had to make a few small tweaks to the code to get the linter to pass. I also updated the GHA workflows to use Node JS 20.x, since that is the latest LTS.
I tried to update the
yarn.lock
andbun.lock
files. I've never used either, so I'm not sure if I did that right.To verify my changes I ran:
Please let me know if I missed anything, or if you'd like any changes made.