Update TTS guide related to completed callback #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
syeonholic
requested review from
journey2w,
mijin85cho,
asm-foysal and
safir-srbd
as code owners
|
Please checkout the webpage https://docs1.stg.tizen.org/staging/1917 |
stom-hwang
approved these changes
Jan 16, 2024
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
stom-hwang
approved these changes
Jan 16, 2024
|
Please checkout the webpage https://docs1.stg.tizen.org/staging/1917 |
safir-srbd
reviewed
Jan 16, 2024
There was a problem hiding this comment.
@syeonholic Hello. Hope you are doing well.
I have gone through the changes you have made and found a few suggestions for you to implement. Please check them.
Comment on lines
250
to
251
| | `UtteranceStarted` | playing the synthesized audio is started | `Ready` > `Playing` | | ||
| | `UtteranceCompleted` | playing the synthesized audio is finished | `Playing` (The state is NOT changed until `Stop()` is called.) | |
There was a problem hiding this comment.
Suggested change
| | `UtteranceStarted` | playing the synthesized audio is started | `Ready` > `Playing` | | |
| | `UtteranceCompleted` | playing the synthesized audio is finished | `Playing` (The state is NOT changed until `Stop()` is called.) | | |
| | `UtteranceStarted` | Playing the synthesized audio is started | `Ready` > `Playing` | | |
| | `UtteranceCompleted` | Playing the synthesized audio is finished | `Playing` (The state is NOT changed until `Stop()` is called.) | |
| | `UtteranceCompleted` | playing the synthesized audio is finished | `Playing` (The state is NOT changed until `Stop()` is called.) | | ||
|
|
||
| > [!NOTE] | ||
| > `UtteranceCompleted` is NOT invoked when |
There was a problem hiding this comment.
Suggested change
| > `UtteranceCompleted` is NOT invoked when | |
| > `UtteranceCompleted` is NOT invoked when the following occurs: |
Comment on lines
256
to
258
| > (1) your application calls `Stop()`. | ||
| > | ||
| > (2) playing the synthesized audio is stopped by other application. |
There was a problem hiding this comment.
Suggested change
| > (1) your application calls `Stop()`. | |
| > | |
| > (2) playing the synthesized audio is stopped by other application. | |
| > (1) Your application calls `Stop()`. | |
| > | |
| > (2) Playing the synthesized audio is stopped by another application. |
Comment on lines
269
to
270
| | Utterance started callback | playing the synthesized audio is started | `TTS_STATE_READY` > `TTS_STATE_PLAYING` | | ||
| | Utterance completed callback | playing the synthesized audio is finished | `TTS_STATE_PLAYING` (The state is NOT changed until `tts_stop()` is called.) | |
There was a problem hiding this comment.
Suggested change
| | Utterance started callback | playing the synthesized audio is started | `TTS_STATE_READY` > `TTS_STATE_PLAYING` | | |
| | Utterance completed callback | playing the synthesized audio is finished | `TTS_STATE_PLAYING` (The state is NOT changed until `tts_stop()` is called.) | | |
| | Utterance started callback | Playing the synthesized audio is started | `TTS_STATE_READY` > `TTS_STATE_PLAYING` | | |
| | Utterance completed callback | Playing the synthesized audio is finished | `TTS_STATE_PLAYING` (The state is NOT changed until `tts_stop()` is called.) | |
| | Utterance completed callback | playing the synthesized audio is finished | `TTS_STATE_PLAYING` (The state is NOT changed until `tts_stop()` is called.) | | ||
|
|
||
| > [!NOTE] | ||
| > Utterance completed callback is NOT invoked when |
There was a problem hiding this comment.
Suggested change
| > Utterance completed callback is NOT invoked when | |
| > Utterance completed callback is NOT invoked when the following occurs: |
Comment on lines
275
to
277
| > (1) your application calls `tts_stop()`. | ||
| > | ||
| > (2) playing the synthesized audio is stopped by other application. |
There was a problem hiding this comment.
Suggested change
| > (1) your application calls `tts_stop()`. | |
| > | |
| > (2) playing the synthesized audio is stopped by other application. | |
| > (1) Your application calls `tts_stop()`. | |
| > | |
| > (2) Playing the synthesized audio is stopped by another application. |
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
|
Please checkout the webpage https://docs1.stg.tizen.org/staging/1917 |
safir-srbd
approved these changes
May 16, 2024
There was a problem hiding this comment.
@syeonholic Thank you for making the suggested changes. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description