[TCSACR-289] Oauth2 C# API deprecated #1206

chauhan321 · 2020-08-13T10:50:19Z

Signed-off-by: kamaljeet chauhan kamal.jc@samsung.com

Change Description

Tizen.Account.OAuth2 is not used by any other module, so deprecating all the public API's of Tizen.Account.OAuth2

Patch info

Samsung/TizenFX#1094

For instance,

ACR: https://code.sec.samsung.net/jira/browse/TCSACR-289

Signed-off-by: kamaljeet chauhan <kamal.jc@samsung.com>

TizenDocsBot · 2020-08-13T10:58:59Z

checkout the webpage https://docs1.stg.tizen.org/staging/1206

journey2w

Please delete OAuth2 in other files as well:

docs/appliation/toc_all.md
docs/application/dotnet/guides/personal/authentication.md

chauhan321 · 2020-08-17T09:49:36Z

Please delete OAuth2 in other files as well:

docs/appliation/toc_all.md

docs/application/dotnet/guides/personal/authentication.md

changes are done, please review

TizenDocsBot · 2020-08-17T09:53:53Z

checkout the webpage https://docs1.stg.tizen.org/staging/1206

TizenDocsBot · 2020-08-17T09:54:04Z

Check Broken Link: Not found any broken link

mijin85cho · 2020-08-18T08:08:29Z

Thanks for the update, @chauhan321.

However, we still have some sentences talking about OAuth 2.0 on application/dotnet/guides/personal/overview.md.
Would you please remove the sentence related with OAuth 2.0?

-   [Authentication and Authorization](authentication.md)

    You can obtain an access token by using the OAuth 2.0 authorization. The OAuth 2.0 authorization framework enables you to obtain limited access to an HTTP service, either on behalf of a resource owner by orchestrating an approval interaction between the resource owner and the HTTP service, or by allowing you to obtain access on your own behalf. You can also use the FIDO Universal Authentication Framework to authenticate users.

In the application/dotnet/tutorials/app-filtering.md file, http://tizen.org/feature/oauth2 is listed up in the table.
I hope you check this page and remove the related feature also.
Also, just a question to application/dotnet/guides/personal/account.md to get your confirmation.
In this page, we have Auth type property in Table: Account properties, related with authentication type.

| Auth type | Integer | No | Authentication type, such as oauth or xauth. |

As oauth module is removed, don't we need to fix this row? I'm not sure with related further update about deprecating OAuth, so asking this question to you.

chauhan321 · 2020-08-20T05:00:14Z

Thanks for the update, @chauhan321.
However, we still have some sentences talking about OAuth 2.0 on application/dotnet/guides/personal/overview.md.
Would you please remove the sentence related with OAuth 2.0?
-   [Authentication and Authorization](authentication.md)

    You can obtain an access token by using the OAuth 2.0 authorization. The OAuth 2.0 authorization framework enables you to obtain limited access to an HTTP service, either on behalf of a resource owner by orchestrating an approval interaction between the resource owner and the HTTP service, or by allowing you to obtain access on your own behalf. You can also use the FIDO Universal Authentication Framework to authenticate users.
In the application/dotnet/tutorials/app-filtering.md file, http://tizen.org/feature/oauth2 is listed up in the table.
I hope you check this page and remove the related feature also.

Also, just a question to application/dotnet/guides/personal/account.md to get your confirmation.
In this page, we have Auth type property in Table: Account properties, related with authentication type.
| Auth type | Integer | No | Authentication type, such as oauth or xauth. |
As oauth module is removed, don't we need to fix this row? I'm not sure with related further update about deprecating OAuth, so asking this question to you.

Changes are done. I am also not sure about account.md file, as it have just mentioned about all properties of account and they can be generic. so i have not deleted from that file.

TizenDocsBot · 2020-08-20T05:04:54Z

checkout the webpage https://docs1.stg.tizen.org/staging/1206

TizenDocsBot · 2020-08-20T05:05:04Z

Check Broken Link: Not found any broken link

mijin85cho

Thanks for the reply, @chauhan321.

Below are my comments with the latest version.

mijin85cho · 2020-08-20T08:08:51Z

docs/application/dotnet/guides/personal/overview.md

@@ -13,10 +13,6 @@ You can use the following personal data features in your .NET applications:

    You can synchronize service application data between a server and the device by creating various sync jobs.

-   [Authentication and Authorization](authentication.md)
-
-    You can obtain an access token by using the OAuth 2.0 authorization. The OAuth 2.0 authorization framework enables you to obtain limited access to an HTTP service, either on behalf of a resource owner by orchestrating an approval interaction between the resource owner and the HTTP service, or by allowing you to obtain access on your own behalf. You can also use the FIDO Universal Authentication Framework to authenticate users.


Oops.. this link should be kept as it is going to authentication.md, which remains after merging this PR. I asked to update just the sentence, as the sentence is mentioning OAuth 2.0 and FIDO Authentication.

Please revert back the removal of this hyperlink, and update the following sentence to mention FIDO Universal Authentication Framework only.

If possible, enhancing the description for FIDO Universal Authentication Framework would be appreciate...

Changes are done, kindly review

The enhancing is more than my expectation. As the introducing, we don't need to use heavy sentences here.

How about below?

You can authenticate users without entering password using FIDO Universal Authentication Framework.

mijin85cho · 2020-08-20T08:14:09Z

docs/application/dotnet/guides/personal/authentication.md

@@ -1,17 +1,13 @@
 # Authentication and Authorization


-The authentication and authorization features introduce how you can obtain access tokens using OAuth 2.0, and authenticate users using the FIDO framework.

 You can use the following authentication and authorization features in your .NET applications:


How about removing authorization from this sentence?

Suggested change

You can use the following authentication and authorization features in your .NET applications:

You can use the following authentication features in your .NET applications:

changes are done, kindly review

TizenDocsBot · 2020-08-20T09:12:10Z

checkout the webpage https://docs1.stg.tizen.org/staging/1206

TizenDocsBot · 2020-08-20T09:12:23Z

Check Broken Link: Not found any broken link

mijin85cho · 2020-08-24T05:00:02Z

Hello, @chauhan321
Would you please check my comment?

mijin85cho
The enhancing is more than my expectation. As the introducing, we don't need to use heavy sentences here.

How about below?

You can authenticate users without entering password using FIDO Universal Authentication Framework.

TizenDocsBot · 2020-08-24T06:24:59Z

checkout the webpage https://docs1.stg.tizen.org/staging/1206

TizenDocsBot · 2020-08-24T06:25:12Z

Check Broken Link: Not found any broken link

chauhan321 · 2020-08-24T07:10:12Z

Hello, @chauhan321
Would you please check my comment?

mijin85cho
The enhancing is more than my expectation. As the introducing, we don't need to use heavy sentences here.
How about below?
You can authenticate users without entering password using FIDO Universal Authentication Framework.

Done

mijin85cho

Thanks for the updates

journey2w · 2020-08-24T07:59:28Z

docs/application/toc_all.md

@@ -186,7 +186,6 @@
 #### Authentication and Authorization
 ##### [Overview](/application/dotnet/guides/personal/authentication.md)
 ##### [FIDO Universal Authentication Framework](/application/dotnet/guides/personal/fido.md)
-##### [OAuth 2.0](/application/dotnet/guides/personal/oauth.md)


We don't recommend creating child nodes when there is only one child.

Suggestion:

... ### Personal Data #### [Overview](/application/dotnet/guides/personal/overview.md) #### [Account Management](/application/dotnet/guides/personal/account.md) #### [Synchronization Management](/application/dotnet/guides/personal/data-sync.md) #### [FIDO Universal Authentication Framework](/application/dotnet/guides/personal/fido.md) #### [Calendar](/application/dotnet/guides/personal/calendar.md) ...

journey2w · 2020-08-24T08:08:50Z

docs/application/dotnet/guides/personal/overview.md

@@ -15,7 +15,7 @@ You can use the following personal data features in your .NET applications:

 -   [Authentication and Authorization](authentication.md)


Could you change this item as follow?

- [FIDO Universal Authentication Framework](fido.md) You can use the FIDO Universal Authentication Framework to authenticate users. FIDO covers password-less authentications, such as fingerprint, iris, and voice.

We don't recommend creating child nodes when there is only one child.
Authentication and Authorization has only one child, fido.md can be a child node of Personal Data.

journey2w · 2020-08-24T08:18:09Z

docs/application/dotnet/guides/personal/authentication.md

@@ -1,17 +1,13 @@
 # Authentication and Authorization


If you think this file, authentication.md, should be reused someday, you can leave this file.
Otherwise, please remove this file.

In the future, there are chances of redesigning of oauth 2.0. Then we may need to reuse this file again. lets keep this file for now.

TizenDocsBot · 2020-08-28T08:23:17Z

checkout the webpage https://docs1.stg.tizen.org/staging/1206

TizenDocsBot · 2020-08-28T08:23:27Z

Check Broken Link: Not found any broken link

duchuyta · 2020-08-31T02:20:33Z

Rerun bot

TizenDocsBot · 2020-08-31T02:30:58Z

checkout the webpage https://docs1.stg.tizen.org/staging/1206

TizenDocsBot · 2020-08-31T02:31:10Z

Check Broken Link: Not found any broken link

chauhan321 · 2020-10-08T07:02:14Z

Hello @journey2w , changes are done. Kindly review

annie-samsung · 2021-08-30T07:37:33Z

@mijin85cho could you suggest what needs to be done with this PR?

ACR-289 Oauth2 C# API deprecated

66f3f7c

Signed-off-by: kamaljeet chauhan <kamal.jc@samsung.com>

chauhan321 requested review from annie-samsung, journey2w and mijin85cho as code owners August 13, 2020 10:50

journey2w requested changes Aug 14, 2020

View reviewed changes

journey2w changed the title ~~ACR-289 Oauth2 C# API deprecated~~ [TCSACR-289] Oauth2 C# API deprecated Aug 14, 2020

review comments incorporated for PR:1206

6473e89

chauhan321 requested a review from journey2w August 17, 2020 09:56

Review comments incorporated for PR-1206

2d33edf

mijin85cho reviewed Aug 20, 2020

View reviewed changes

Modified authentication doc for aouth2 related changes

8b5a180

chauhan321 requested a review from mijin85cho August 24, 2020 04:19

incorporated review comments on PR-1206

82921f1

mijin85cho approved these changes Aug 24, 2020

View reviewed changes

journey2w requested changes Aug 24, 2020

View reviewed changes

incorporated review comments of PR-1206

77f1a38

chauhan321 added 2 commits August 28, 2020 14:25

Merge branch 'master' into tizen_5.5_prepare

f8f9885

Update toc_all.md

c1ca057

duchuyta closed this Aug 31, 2020

duchuyta reopened this Aug 31, 2020

journey2w force-pushed the master branch 3 times, most recently from 81a8739 to b4510fa Compare December 2, 2020 10:26

	You can use the following authentication and authorization features in your .NET applications:
	You can use the following authentication features in your .NET applications:

		@@ -15,7 +15,7 @@ You can use the following personal data features in your .NET applications:

		- [Authentication and Authorization](authentication.md)

[TCSACR-289] Oauth2 C# API deprecated #1206

Are you sure you want to change the base?

[TCSACR-289] Oauth2 C# API deprecated #1206

Conversation

chauhan321 commented Aug 13, 2020 • edited by journey2w

Change Description

Patch info

TizenDocsBot commented Aug 13, 2020

journey2w left a comment

Choose a reason for hiding this comment

chauhan321 commented Aug 17, 2020

TizenDocsBot commented Aug 17, 2020

TizenDocsBot commented Aug 17, 2020

mijin85cho commented Aug 18, 2020

chauhan321 commented Aug 20, 2020 • edited

TizenDocsBot commented Aug 20, 2020

TizenDocsBot commented Aug 20, 2020

mijin85cho left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TizenDocsBot commented Aug 20, 2020

TizenDocsBot commented Aug 20, 2020

mijin85cho commented Aug 24, 2020

TizenDocsBot commented Aug 24, 2020

TizenDocsBot commented Aug 24, 2020

chauhan321 commented Aug 24, 2020

mijin85cho left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TizenDocsBot commented Aug 28, 2020

TizenDocsBot commented Aug 28, 2020

duchuyta commented Aug 31, 2020

TizenDocsBot commented Aug 31, 2020

TizenDocsBot commented Aug 31, 2020

chauhan321 commented Oct 8, 2020 • edited

annie-samsung commented Aug 30, 2021

chauhan321 commented Aug 13, 2020 •

edited by journey2w

chauhan321 commented Aug 20, 2020 •

edited

chauhan321 commented Oct 8, 2020 •

edited