os/arch/arm/src/amebasmart: I2C/I2S integration with PM #6181
Conversation
| switch (pmstate) | ||
| { | ||
| case PM_NORMAL: | ||
| pmu_unregister_sleep_callback(PMU_I2C_DEVICE); |
There was a problem hiding this comment.
This means the pm state should be normal at wakeup? I heard it could be the standby when LCD is used. For example, lcd should not be turned on but something should be working (main core should be wakeup without lcd on). In this case, is this right? @ritesh55555 please check this.
There was a problem hiding this comment.
- Yes , for now , whenever board wakes up with an interrupt, pm state goes to NORMAL .
- When LCD is used, according the design given (lcd and pm) , pm should go to stand by state . So if we do that , we need to change this part and also in some other files also.
There was a problem hiding this comment.
PM_NORMAL can be set in several situations.
This may not be the case when the main core wakes up.
I think it's a better way to restore this function directly from the pmu code in BSP than this.
The noti callback of this PM is not a feature for the BSP
There was a problem hiding this comment.
Hi all, I have pushed a commit to move the pre/post sleep callbacks to being done only during initialization stage.
edwakuwaku
force-pushed
the
power_save_update
branch
from
9cd581b
to
90db87e
Compare
- Prepare pre/post sleep process for I2C/I2S
- Move callbacks registration to be done at bootup stage, due to the PM is always needed - Code cleanup
edwakuwaku
force-pushed
the
power_save_update
branch
from
90db87e
to
d4002e9
Compare
No description provided.