Add RTL8730E board revision 5th #6180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewoodev
force-pushed
the
WORK-240510_add_revision
branch
from
fe586a4
to
8907225
Compare
ewoodev
force-pushed
the
WORK-240510_add_revision
branch
3 times, most recently
from
8bf9acb
to
b70bf87
Compare
edwakuwaku
reviewed
May 13, 2024
ewoodev
force-pushed
the
WORK-240510_add_revision
branch
2 times, most recently
from
46d0aab
to
8342e28
Compare
os/board/rtl8730e/Kconfig
Outdated
| @@ -36,6 +36,13 @@ config BOARD_FLASH_16M | |||
|
|
|||
| endchoice | |||
|
|
|||
| config RTL8730E_REVISION | |||
There was a problem hiding this comment.
- RTL8730E_BOARD_REVISION?
- But this may make someone mis-understand the chipset revision....
os/board/rtl8730e/Kconfig
Outdated
| @@ -36,6 +36,13 @@ config BOARD_FLASH_16M | |||
|
|
|||
| endchoice | |||
|
|
|||
| config RTL8730E_REVISION | |||
| int "Select target board revision version" | |||
There was a problem hiding this comment.
Let's remove "version" here as well.
os/board/rtl8730e/Kconfig
Outdated
| int "Select target board revision version" | ||
| default 0 | ||
| ---help--- | ||
| Select the board revision version. |
ewoodev
force-pushed
the
WORK-240510_add_revision
branch
2 times, most recently
from
29a7219
to
3368897
Compare
The pins of the periphery may vary for each new board. To adjust the pins of the periphery for each board, a CONFIG_RTL8730E_BOARD_REVISION configuration is added. Signed-off-by: eunwoo.nam <eunwoo.nam@samsung.com>
ewoodev
force-pushed
the
WORK-240510_add_revision
branch
from
3368897
to
14efa45
Compare
Add the revised 5th board. The pin of UART1 has been changed. The ALC1019 I2C port has been changed. Signed-off-by: eunwoo.nam <eunwoo.nam@samsung.com>
ewoodev
force-pushed
the
WORK-240510_add_revision
branch
from
14efa45
to
ac6277d
Compare
sunghan-chang
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.