tools/trap: add trap tool support for xip loadable apps #6179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neel-samsung
changed the title
r-prabu
reviewed
May 8, 2024
| @@ -28,6 +28,7 @@ | |||
| debug = False # Variable to print debug logs | |||
| pc_value = 0x00000000 # Program counter value | |||
| format_print = True | |||
| CONFIG_PATH = '../../os/.config' | |||
There was a problem hiding this comment.
instead of hardcode path can we have CONFIG_PATH like which is used in the ramdumpparser.py?
There was a problem hiding this comment.
we are also setting CONFIG_PATH in ramdumpParser.py at start.
TizenRT/tools/trap/ramdumpParser.py
Line 56 in 849427e
Since, we need it here, then we need to define here also.
There was a problem hiding this comment.
As far as I know, the tool provides selectable options for this.
- use default values
- get user input for this
Is it the same? We should concern this can be executed without source code.
add trap tool support for xip loadable apps. As loadable apps requires offset(app start address) to be subtracted from application text address whereas with xip, we don't need to subtract it while using address to line command in trap tool. Signed-off-by: Neelkumar Patel <neel.patel@samsung.com>
neel-samsung
changed the title
| @@ -28,6 +28,7 @@ | |||
| debug = False # Variable to print debug logs | |||
| pc_value = 0x00000000 # Program counter value | |||
| format_print = True | |||
| CONFIG_PATH = '../../os/.config' | |||
There was a problem hiding this comment.
As far as I know, the tool provides selectable options for this.
- use default values
- get user input for this
Is it the same? We should concern this can be executed without source code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add trap tool support for xip loadable apps