os/include/tinyara/security_hal.h: Add AES-GCM mode #6178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add AES-GCM mode and parameter to support AES-GCM encryption/decryption. AES-GCM mode needs 4 additional parameter. - AAD (Additional Authentication Data) - AAD length - TAG (Authentication Tag) - TAG length
Comment on lines
+222
to
+232
| #ifdef CONFIG_HW_AES_GCM_ENC | ||
| #define HAL_AES_PARAM_INITIALIZER \ | ||
| { \ | ||
| HAL_AES_UNKNOWN, NULL, 0, NULL, NULL, NULL, NULL, NULL, 0, NULL, 0 \ | ||
| } | ||
| #else | ||
| #define HAL_AES_PARAM_INITIALIZER \ | ||
| { \ | ||
| HAL_AES_UNKNOWN, NULL, 0, NULL, NULL, NULL, NULL \ | ||
| } | ||
| #endif |
There was a problem hiding this comment.
How about below? You don't need to maintain duplicated values and it's easy to know AES_GCM requries 4 more params I think.
#define HAL_AES_PARAM_INITIALIZER \
{ \
HAL_AES_UNKNOWN, NULL, 0, NULL, NULL, NULL, NULL \
#ifdef CONFIG_HW_AES_GCM_ENC
, NULL, 0, NULL, 0 \
#endif
}
Comment on lines
+188
to
+189
| /* Additional authentication data | ||
| * to generate tag */ |
There was a problem hiding this comment.
/* Additional authentication data
* to generate tag
* /
There was a problem hiding this comment.
But It looks short enough. Do we need to use 2 lines?
Comment on lines
+47
to
+48
| config HW_AES_GCM_ENC | ||
| bool "HW AES GCM encryption decryption" |
There was a problem hiding this comment.
The config name is ENC but explanation says encryption descryption. What is correct?
Comment on lines
+106
to
+108
| #ifdef CONFIG_HW_AES_GCM_ENC | ||
| HAL_AES_GCM, | ||
| #endif |
There was a problem hiding this comment.
How about adding that without the conditional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AES-GCM mode and parameter to support AES-GCM encryption/decryption. AES-GCM mode needs 4 additional parameter.