Add kernel testcases #6177
Open
Add kernel testcases #6177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of kernel module testcases
| tc_environ_setenv_getenv_unsetenv_pos(); | ||
| tc_environ_getenv_neg(); | ||
| tc_environ_setenv_name_null_neg(); | ||
| tc_environ_setenv_empty_name_neg(); |
There was a problem hiding this comment.
Please check indentation.
| @@ -45,7 +45,7 @@ | |||
| * Preconditions :none | |||
| * Postconditions :none | |||
| */ | |||
| static void itc_environ_setenv_p(void) | |||
There was a problem hiding this comment.
We check _p and _n internally in the automation tool. Do you have any reason to change?
| @@ -62,6 +62,6 @@ static void itc_libc_semaphore_getprotocol_n_no_sem_init(void) | |||
|
|
|||
| int itc_libc_semaphore_main(void) | |||
| { | |||
| itc_libc_semaphore_getprotocol_n_no_sem_init(); | |||
| itc_libc_semaphore_getprotocol_no_sem_init_neg(); | |||
There was a problem hiding this comment.
same as previous
u/itc_module_feature_function_n/p_details
This is what we use in the naming and automation tool parses.
Please let me know why you change the naming.
| tc_clock_clock_get_time_pos(); | ||
| tc_clock_clock_set_time_pos(); | ||
| tc_clock_clock_set_time_neg(); | ||
| tc_clock_clock_getres_pos(); |
There was a problem hiding this comment.
Please check indentation
Comment on lines
+63
to
+64
|
|
||
|
|
There was a problem hiding this comment.
Let's keep just 1 empty line for separating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel testcases are modified to segregate it a positive and negative.