os/board/rtl8730e: Prepare PM for GPIO #6175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
edwakuwaku
commented
May 7, 2024
edwakuwaku
commented
- Prepare PM for GPIO
edwakuwaku
changed the title
edwakuwaku
force-pushed
the
gpio_pm
branch
2 times, most recently
from
ba9611a
to
7c6b0b1
Compare
- Prepare PM for GPIO
edwakuwaku
commented
May 13, 2024
os/pm/pm_wakehandler.c
Outdated
| @@ -55,7 +55,7 @@ void pm_wakehandler(clock_t missing_tick) | |||
| { | |||
| irqstate_t flags = enter_critical_section(); | |||
|
|
|||
| pmllvdbg("missing_tick: %d\n", missing_tick); | |||
| pmllvdbg("missing_tick: %lld\n", missing_tick); | |||
There was a problem hiding this comment.
Hi @ewoodev , the clock_t is using u64, %d is printing wrong value, thus I changed to %lld here.
There was a problem hiding this comment.
Thank you for change edwakuwaku
this value is usinged long long, so Could you please apply %llu ?
There was a problem hiding this comment.
Hi EunWoo님, thanks for reminding, changed accordingly~
|
Hello @ewoodev , @ritesh55555 , other than enabling GPIO as wakeup src, this PR also added informational log to show the wakeup src. For wifi-keepalive, it will also show the packet type received that triggers wakeup. |
edwakuwaku
changed the title
ewoodev
reviewed
May 21, 2024
build/tools/amebasmart/gnu_utility/km0_km4_app_RELEASE_NOTE.txt
Outdated
Show resolved
Hide resolved
- Enable GPIO channel A as wakeup interrupt src
- Remove some logs, change tick printing to %llu because we are using u64 for clock_t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.