Enable audio configs on loadable_ext of RTL8730E #6165
Conversation
abhishek-samsung
changed the title
abhishek-samsung
changed the title
|
None of the test code for media is enabled in the current PR as it will result in build failure. The build issues can be resolved by applying exceptions PR #6068 . However, cout is still not working, so it must be avoided for now. I have tested media player (adding code without cout) after applying #6068 and its working fine. |
abhishek-samsung
force-pushed
the
audio_configs
branch
from
ed325d3
to
595e598
Compare
Done |
abhishek-samsung
force-pushed
the
audio_configs
branch
from
595e598
to
48ed636
Compare
| @@ -8,7 +8,6 @@ config MEDIA | |||
| default n | |||
| depends on AUDIO | |||
| select HAVE_CXX | |||
| select HAVE_CXXINITIALIZE | |||
There was a problem hiding this comment.
Could you leave where this is concerned in a Kconfig in the commit description?
There was a problem hiding this comment.
Sorry, I didnt understand. Do I need to update the commit description on why I removed this line?
There was a problem hiding this comment.
Because this select is done in other config, we remove this.
I want to leave
- why this config should be enabled
- who enables this automatically instead of here
There was a problem hiding this comment.
I have updated the commit description.
abhishek-samsung
force-pushed
the
audio_configs
branch
2 times, most recently
from
85fa695
to
eb1fabe
Compare
When C++ is enabled, we select HAVE_CXXINITIALIZE or BINFMT_CONSTRUCTORS in lib/libxx/Kconfig. So, no need to again select them if we already have added dependency on C++. And added auto select ARCH_BOARD_HAVE_SECOND_FLASH for RTL8730E if h/w revision is >= 5. Signed-off-by: Abhishek Akkabathula <a.akkabathul@samsung.com>
Signed-off-by: Abhishek Akkabathula <a.akkabathul@samsung.com>
abhishek-samsung
force-pushed
the
audio_configs
branch
from
eb1fabe
to
0d84b48
Compare
No description provided.