Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updation of MBEDTLS to version 3.4.0 #6118

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

samsung-singh
Copy link

With this PR MBEDTLS is updated from v2.7.8 to v3.4.0 in TizenRT

@jylee9613
Copy link
Contributor

jylee9613 commented Mar 26, 2024

There are some build error in CircleCI.
Please check and resolve the build error.

Also, would you please let me know how did you test mbedtls functions, and what configuration did you use?
CircleCI is only succeed in TP1x flat build.

@sunghan-chang
Copy link
Contributor

You should not remove the Samsung license.

@samsung-singh
Copy link
Author

There are some build error in CircleCI. Please check and resolve the build error.

Also, would you please let me know how did you test mbedtls functions, and what configuration did you use? CircleCI is only succeed in TP1x flat build.

we verified mbedtls through DA application but we were looking for extensive unit testing for mbedtls. It would be really helpful if you can share the test procedure followed in earlier mbedtls updates, so that we can make sure the functionality of mbedtls in this update.

@samsung-singh
Copy link
Author

You should not remove the Samsung license.

sure we will take care of it.

@jylee9613
Copy link
Contributor

jylee9613 commented Apr 8, 2024

There are some build error in CircleCI. Please check and resolve the build error.
Also, would you please let me know how did you test mbedtls functions, and what configuration did you use? CircleCI is only succeed in TP1x flat build.

we verified mbedtls through DA application but we were looking for extensive unit testing for mbedtls. It would be really helpful if you can share the test procedure followed in earlier mbedtls updates, so that we can make sure the functionality of mbedtls in this update.

You can use mbedtls_self_main to test mbedtls APIs.

@samsung-singh
Copy link
Author

You should not remove the Samsung license.

There are some new files added, do we need samsung license in all the files or in modified files only? because some files are same as in open source.

@jylee9613
Copy link
Contributor

You should not remove the Samsung license.

There are some new files added, do we need samsung license in all the files or in modified files only? because some files are same as in open source.

You have to add samsung license in all the files.

@samsung-singh
Copy link
Author

all test cases in mbedtls_self have passed

external/include/mbedtls/alt/aes_alt.h Outdated Show resolved Hide resolved
external/include/mbedtls/aria.h Outdated Show resolved Hide resolved
external/mbedtls/alt/Make.defs Outdated Show resolved Hide resolved
external/mbedtls/alt/alt_utils.c Outdated Show resolved Hide resolved
@jylee9613
Copy link
Contributor

@samsung-singh Please move all header files in external/mbedtls to external/include/mbedtls

@samsung-singh
Copy link
Author

@samsung-singh Please move all header files in external/mbedtls to external/include/mbedtls

In Mbedtls 3.4.0 open source, some header files are added in mbedtls library instead of include/mbedtls, should we move those header files as per TizenRT?

@jylee9613
Copy link
Contributor

@samsung-singh Please move all header files in external/mbedtls to external/include/mbedtls

In Mbedtls 3.4.0 open source, some header files are added in mbedtls library instead of include/mbedtls, should we move those header files as per TizenRT?

Oh, okay. Then leave those headers where they are. Thanks.

@jylee9613
Copy link
Contributor

we verified mbedtls through DA application but we were looking for extensive unit testing for mbedtls. It would be really helpful if you can share the test procedure followed in earlier mbedtls updates, so that we can make sure the functionality of mbedtls in this update.

You can use mbedtls_self_main to test mbedtls APIs.

Hello @samsung-singh
When you test _alt APIs, please turn on HW_TLS configs.
You can enable it in menuconfig.
Network Support - Protocols - TLS Support - Enable HW Accelrator - HW Options - Use H/W aes/ecdsa/...

Also, there are tls test code in apps/examples/tls.
tls_selftest_main is almost same as mbedtls_self_main, so please add testcases in here too.

You can check tls and dtls process by using tls_server / tls_client and dtls_server / dtls_client.
After the updation, please check this test too.

@samsung-singh
Copy link
Author

we verified mbedtls through DA application but we were looking for extensive unit testing for mbedtls. It would be really helpful if you can share the test procedure followed in earlier mbedtls updates, so that we can make sure the functionality of mbedtls in this update.

You can use mbedtls_self_main to test mbedtls APIs.

Hello @samsung-singh When you test _alt APIs, please turn on HW_TLS configs. You can enable it in menuconfig. Network Support - Protocols - TLS Support - Enable HW Accelrator - HW Options - Use H/W aes/ecdsa/...

Also, there are tls test code in apps/examples/tls. tls_selftest_main is almost same as mbedtls_self_main, so please add testcases in here too.

You can check tls and dtls process by using tls_server / tls_client and dtls_server / dtls_client. After the updation, please check this test too.

sure, I will test with HW_TLS configs, thanks for notifying.

external/mbedtls/alt/ecdh_alt.c Outdated Show resolved Hide resolved
external/mbedtls/alt/ecdh_alt.c Outdated Show resolved Hide resolved
external/mbedtls/alt/ecdh_alt.c Outdated Show resolved Hide resolved
external/mbedtls/alt/ecdh_alt.c Outdated Show resolved Hide resolved
external/mbedtls/alt/pk_wrap_alt.c Show resolved Hide resolved
external/include/mbedtls/alt/common.h Outdated Show resolved Hide resolved
external/include/mbedtls/mbedtls_tizenrt_config.h Outdated Show resolved Hide resolved
external/mbedtls/alt/pk_wrap_alt.c Outdated Show resolved Hide resolved
external/include/mbedtls/aes.h Outdated Show resolved Hide resolved
external/include/mbedtls/ssl_internal.h Outdated Show resolved Hide resolved
external/mbedtls/ssl_misc.h Outdated Show resolved Hide resolved
external/include/mbedtls/ssl_misc.h Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants