os/board/rtl8730e,os/arch/arm/src/amebasmart: Amebasmart USB host driver #6083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes USB host class CDC ACM Changes in irq attachment, due to the replacement of M-cortex and A-cortex APcore, LSB 1 is not required for thumb architecture see comment in osdep_service_misc.c
Taejun-Kwon
reviewed
Mar 4, 2024
| ts.tv_sec ++; | ||
| ts.tv_nsec -= NSEC_PER_SEC; | ||
| } | ||
| if (mq_timedreceive((mqd_t) *queue, message, ((mqd_t) *queue)->msgq->maxmsgsize, &prio, &ts) == ERROR) { |
There was a problem hiding this comment.
Is there any specific reason why use mq among the kernel features? if you added this for yout testing, then please add some define or config only for your test
There was a problem hiding this comment.
Hi @Taejun-Kwon ,
In USB operation, we used queue in our FreeRTOS OS, an alternative in Nuttx is mq. Would there be issue using this?
Kai
There was a problem hiding this comment.
because this will share some of result with Virtual driver of USB(dev/usb or something), I think callback mechanism is enough in kernel side. Chracter Device, should share result with Application message queue because only IPC allowed between kernel & app
There was a problem hiding this comment.
Hi Taejun,
I will try a work around.
Kai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes USB host class CDC ACM
Changes in irq attachment, due to the replacement of M-cortex and A-cortex APcore, LSB 1 is not required for thumb architecture see comment in osdep_service_misc.c