external/mbedtls/config.h: Enable MBEDTLS_AES_ROM_TABLES #6080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If MBEDTLS_AES_ROM_TABLES is disabled, aes_gen_tabels() calculate S-Box table and save it in the static buffers. However, S-Box table is unchanged unless the seed is changed, and there was no operation to change the seed. Therefore, this commit enables MBEDTLS_AES_ROM_TABLES to save S-Box tables as const (to remove unnecessary static memory)
sunghan-chang
approved these changes
Feb 27, 2024
|
@j11591 Could you review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If MBEDTLS_AES_ROM_TABLES is disabled, aes_gen_tabels() calculate S-Box table and save it in the static buffers.
However, S-Box table is unchanged unless the seed is changed, and there was no operation to change the seed.
Therefore, this commit enables MBEDTLS_AES_ROM_TABLES to save S-Box tables as const (to remove unnecessary static memory)