os/arch/arm/src/amebasmart, os/board/rtl8730e: Update critical zone API usage for SMP #6079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
edwakuwaku
commented
Feb 27, 2024
•
edwakuwaku
commented
- Change to use enter/leave_critical_section instead of irqsave/irqrestore, for both arch and driver layer
- Reduce overhead for critical zone implementation in porting layer
- Driver Features verification pending due to several logic crashes
- Related PR: os, lib: Fix build errors for SMP with loadable apps #6049
edwakuwaku
force-pushed
the
smp_update
branch
3 times, most recently
from
368144a
to
fea7aa2
Compare
edwakuwaku
force-pushed
the
smp_update
branch
2 times, most recently
from
c1a1fd2
to
1ca8c91
Compare
edwakuwaku
force-pushed
the
smp_update
branch
2 times, most recently
from
4560986
to
e9c25c6
Compare
edwakuwaku
changed the title
- Change irqsave/irqrestore to enter/leave_critical_section
- Reduce overhead of implementation in osdep_service_critical.c - Update SMP mechanism for IPC part
- A deadlock was observed when the cpuA which undergo flash operation is trying to gate the other cpuB, but the cpuB is in critical zone (ie. interrupt disabled state), due to waiting for cpuA to pause itself - This commit fix the deadlock issue by letting cpuA to check and handle any pending pause request at first, so that cpuB can continue it's workflow and exit from critical zone, thus it can handle the gating request from cpuA
Merged
sunghan-chang
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.