New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build/tools/amebasmart: Change KM4 version print location #6060
base: master
Are you sure you want to change the base?
Conversation
jwei5
commented
Feb 15, 2024
- Change KM4 version print location from CA32 to KM4
- KM4 version info will be printed during wifi_netmgr_utils_init, similar to rtl8721
Log of KM4 version info before PR:
Log of KM4 version after changing print location:
|
@jwei5 Could you let us know why you change the location of printing? |
Hi @sunghan-chang, for the current print location in TizenRT, the KM4 version info is hard coded and has to be manually changed when KM4 image is updated. |
@jwei5 At init time, we print some mandatory logs. They should not be corrupted. Because of this, we got many issues on RTL8721CSM. If it does not cause log mixed, anywhere is ok. Please make sure that this log does not cause log mixed. |
@jwei5 Any update? and need to resolve the conflicts |
Hi @sunghan-chang, we have an IPC function that is able to send selected KM4 logs over to CA32 to print. To prevent mixed logs, we can use this function to print the version information in CA32 instead of printing at KM4 directly. However, this function is controlled over at CA32 TizenRT and it is currently disabled by default. It needs to enabled by calling inic_ipc_buffered_printf_set_np_enable(1). Is it ok if we enable this function by default? |
@jwei5 I don't know what it is. Without pros and cons of enabling, I can't give you my opinion. Why do you keep it disabled until now? |
@jwei5 Whatever it is, we should prevent log mixed. That's the most important thing. |
Dear @sunghan-chang , then we will enable ipc buffered print and update the PR, thank you |
@sunghan-chang , your concern makes sense, we will only use ipc buffered print for this km4 version print, so will not cause performance degradation. |
* Change KM4 version info to be obtained from KM4 instead of CA32 * To prevent mixed logs when printing version info, use ipc buffered print to send KM4 version info to CA32 and print at CA32 * Enable inic_ipc_buffered_printf_set_np_enable() to enable use of ipc buffered print * KM4 version info will be printed during boot up
Hi @sunghan-chang , I have made the changes for printing KM4 version info to use ipc buffered print to prevent the issue of mixed logs. The KM4 version info will be printed during system boot up: |
@jwei5 @gexuyan Thank you for update. But could you check belows?
|
Hi @sunghan-chang , there are other logs in KM4 which are mostly warning/error logs that are only printed when there is an issue with the KM4 driver. For these logs, they are currently printed in KM4. |