[luci-interpreter] Add a feature to infer the output shape #12980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows the interpreter to determine the unknown output shape, when it is able to infer the output shape. As a result, the output value of the inferred unknown shape can also be output. Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
shs-park
commented
May 10, 2024
Comment on lines
139
to
140
| std::vector<char> output_data(getTensorSize(output_node)); | ||
| size_t output_size = interpreter.getOutputTensorSize(output_node); | ||
| std::vector<char> output_data(output_size); |
There was a problem hiding this comment.
Change to get the size of output_node from the runtime module, not from the shape of origin model.
The runtime module can have inferred shape which is determined in interpreting process.
|
plz split |
Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
@seanshpark, |
seanshpark
reviewed
May 10, 2024
| if (tensor == nullptr) | ||
| { | ||
| const std::string &name = output_node->name(); | ||
| throw std::runtime_error("Cannot find tensor size for output node named \"" + name + "\"."); |
There was a problem hiding this comment.
NOTE other methods in this file uses throw std::runtime_error() for failure exit.
jinevening
approved these changes
May 13, 2024
There was a problem hiding this comment.
LGTM w/ minor comment (https://github.com/Samsung/ONE/pull/12981/files#r1598051074).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a new interface
getOutputTensorSizein the luci-interpreter.This is to get the size of actual output size from the
_runtime_module, which has the inferred and calculated output shape during the interprete process.for issue #12979
from draft #12981