[DRAF][one-optimize] Optimize part of the transformer's attention-head #12918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalyshevArtem
added
the
DRAFT
This draft introduces two new passes to optimize part of the transformer's attention-head: FuseMulWithFullyConnected and FuseStridedSlicesNegAsMul. ONE-DCO-1.0-Signed-off-by: Artem Balyshev <a.balyshev@samsung.com>
BalyshevArtem
force-pushed
the
opt_trans_1
branch
from
75b73de
to
8974450
Compare
|
|
some comments;
|
BalyshevArtem
force-pushed
the
opt_trans_1
branch
from
faf419e
to
fd5b254
Compare
added 3 commits
May 2, 2024 12:28
Done |
|
@seanshpark, can I split this draft into PRs? |
Yes, please do :) |
jinevening
reviewed
May 8, 2024
Comment on lines
+97
to
+98
| input: "output_1" | ||
| input: "output_neg" |
There was a problem hiding this comment.
In the target model, the inputs are swapped. PTAL #12917 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft introduces two new passes to optimize part of the transformer's attention-head: FuseMulWithFullyConnected and FuseStridedSlicesNegAsMul.
for issue: #12917
ONE-DCO-1.0-Signed-off-by: Artem Balyshev a.balyshev@samsung.com