New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix svace issue Redundant null check #518
Conversation
Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
============================================
- Coverage 91.34% 91.33% -0.01%
+ Complexity 517 516 -1
============================================
Files 48 48
Lines 1733 1731 -2
Branches 209 208 -1
============================================
- Hits 1583 1581 -2
Misses 83 83
Partials 67 67 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request
Description
PR contains a fix for the issue Redundant nullcheck of repoLicense.
Also, after modification of the main code, unit tests were updated as well.
Type of change
Please delete options that are not relevant.
Testing
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Test Configuration:
Checklist: