JWT & Auth rules improvement #549
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babenek
commented
Apr 30, 2024
xDizzix
requested changes
May 2, 2024
| @@ -304,16 +304,15 @@ | |||
|
|
|||
| - name: JSON Web Token | |||
| severity: medium | |||
| confidence: moderate | |||
| confidence: strong | |||
There was a problem hiding this comment.
I think it a controversial statement that the JSON encoded in base64 is a security threat
| def __init__(self, config: Config = None) -> None: | ||
| pass | ||
|
|
||
| def run(self, line_data: LineData, target: AnalysisTarget) -> bool: |
There was a problem hiding this comment.
The checker is very loose. It must be more strict, at least check the inner structure for the presence of some security-related keywords.
| @@ -100,5 +97,32 @@ def evaluate_avg(_args: Tuple[int, float, float]) -> Tuple[float, float]: | |||
| # 31 = (4.5121865964712535, 0.1393228408491736) | |||
| # 32 = (4.545556887485041, 0.13347416608982715) | |||
| # 33 = (4.576938427997454, 0.1300362152603773) | |||
|
|
|||
| # 33 = (4.57601357276539, 0.13672208599146715) | |||
There was a problem hiding this comment.
Please describe what is this data for
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which is fixed.
How has this been tested?
Please describe the tests that you ran to verify your changes.