Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan oversized lines by chunks #522

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Mar 3, 2024

Description

Please include a summary of the change and which is fixed.

  • Add chunk-based scan for oversized lines with overlap to do not skip a credential between chunks
  • slowdown ~26%

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 90.53%. Comparing base (21a54c9) to head (903ea75).

Files Patch % Lines
credsweeper/scanner/scan_type/scan_type.py 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #522   +/-   ##
=======================================
  Coverage   90.53%   90.53%           
=======================================
  Files         127      127           
  Lines        4394     4397    +3     
  Branches      707      707           
=======================================
+ Hits         3978     3981    +3     
  Misses        274      274           
  Partials      142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rollback

.github/workflows/benchmark.yml Outdated Show resolved Hide resolved
.github/workflows/benchmark.yml Outdated Show resolved Hide resolved
.github/workflows/benchmark.yml Outdated Show resolved Hide resolved
.github/workflows/benchmark.yml Outdated Show resolved Hide resolved
@babenek babenek marked this pull request as ready for review March 6, 2024 14:18
@babenek babenek requested a review from a team as a code owner March 6, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants