Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category contains rules list #124

Merged
merged 157 commits into from May 20, 2024
Merged

Category contains rules list #124

merged 157 commits into from May 20, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented May 4, 2024

  • update Category data with according rules list. In common case "Password" is kept as is. If markup have many rules - use : for split them.
  • Benchmark was refactored to display result for each rule: markup stat, reported , TP, FP and so on
  • readme updated
  • PR for the test: [BM] Category contains rules list CredSweeper#553

@babenek babenek changed the title Category2rules Category contains rules list May 16, 2024
@babenek babenek marked this pull request as ready for review May 16, 2024 10:00
@babenek babenek requested a review from a team as a code owner May 16, 2024 10:00
update_meta.py Outdated



# for k, v in meta_dict.items():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please clean the annotations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was temporally file for auto markup.

@babenek babenek requested a review from csh519 May 17, 2024 05:47
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@babenek babenek merged commit 583494b into Samsung:main May 20, 2024
4 checks passed
@babenek babenek deleted the category2rules branch May 20, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants