Upgrading to Angular 8 #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 13, 2019 21:11
- Upgrading minor version.
Nightbr
reviewed
Dec 13, 2019
| "ng6", | ||
| "ngx", | ||
| "embed-video", | ||
| "embed", | ||
| "typescript", |
There was a problem hiding this comment.
Why remove typescript tag?
There was a problem hiding this comment.
I removed it as it's duplicated. It's at the top of this list.
| ], | ||
| "license": "MIT", | ||
| "bugs": { | ||
| "url": "https://github.com/SamirHodzic/ngx-embed-video/issues" | ||
| }, | ||
| "main": "./dist/index.js", | ||
| "peerDependencies": { | ||
| "@angular/core": "^6.0.0", |
There was a problem hiding this comment.
Why remove this & remove common but not core?
There was a problem hiding this comment.
The ng update command took care of this 🙂.
|
any update on upgrading to angular 8 |
|
Are you planning to support for Angular 8. |
|
This is not at all compatible with Ivy. so if you use angular 9 with Ivy or angular 10 the all thing breaks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.