Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatTable features #749

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

MatTable features #749

wants to merge 4 commits into from

Conversation

HClausing
Copy link

@HClausing HClausing commented Oct 10, 2020

Suggested implementations:

  • ColGroup tag before thead :

image

  • OnRowGenerating custom action, after tbody rendering. It will allow to create dictionaries (by ex.) with object instance (from list) and ElementReference. It's usefull when you want to create a button on TableRow with drop down Menu, for set its reference to Menu instance when clicked. It's optional.

image

Best regards.

akovac35 and others added 4 commits August 3, 2020 11:26
Fixed a null reference exception.
Fix null reference exception for multi column filtering in MatTable
- ColGroup tag before <thead> ;

- OnRowGenerating custom action, after <tbody> rendering. It will allow to create dictionaries (by ex.) with object instance (from list) and ElementReference. It's usefull when you want to create a button on TableRow with drop down Menu, for set its reference to Menu instance when clicked.
This was referenced Oct 10, 2020
@HClausing HClausing changed the base branch from master to develop October 24, 2020 11:26
@HClausing
Copy link
Author

Fixed target branch from 'master' to 'develop'.

@HClausing HClausing changed the base branch from develop to master October 27, 2020 10:54
@HClausing HClausing changed the base branch from master to develop October 27, 2020 10:55
@SamProf
Copy link
Owner

SamProf commented Nov 1, 2020

Hi @HClausing.
Thank you for your contribution.
I have few questions.

  • You added MatColGroup - good idea. I have proposition. I don't feel that wee need MatColGroup > colgroup.
    Now you have this API:
<MatColGroup>
                <colgroup>
                    <col span="1" style="width: 60%;">
                    <col span="1" style="width: auto;">
                    <col span="1" style="width: auto;">
                </colgroup>
</MatColGroup>

I propose this:

<MatColGroup>
                    <col span="1" style="width: 60%;">
                    <col span="1" style="width: auto;">
                    <col span="1" style="width: auto;">
</MatColGroup>
  • Can you show real-life example of using OnRowsGenerating?

@sdktraceur
Copy link

When this will be implemented?

@ldcroberts
Copy link

ldcroberts commented Mar 1, 2021

I would say go with <MatColGroup><col> directly and don't worry about onrowsgenerating yet.
The ability to have a working/consistent column width specification is actually quite important

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants