Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate script: review of command-line arguments #172

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sfmig
Copy link
Collaborator

@sfmig sfmig commented Apr 18, 2024

  • Use datamodule/dataset from checkpoint if not specified:
    evaluate-detector --checkpoint_path /path/to/ml-runs/612070585685391606/b640975fb8d74ee4ac07f05908cb3350/checkpoints/last.ckpt --accelerator cpu

  • Split config into sections

  • CLI arg iou_threshold was not being used (config instead)

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 36.18%. Comparing base (7362430) to head (03b6664).

Files Patch % Lines
crabs/detection_tracking/evaluate_model.py 0.00% 44 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   37.18%   36.18%   -1.00%     
==========================================
  Files          19       19              
  Lines        1307     1343      +36     
==========================================
  Hits          486      486              
- Misses        821      857      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig changed the title Evaluate CLI rev Evaluate script: review of command-line arguments Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants