Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some contrast issues of the text in darkmode. #65

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elyassaf
Copy link

@elyassaf elyassaf commented Oct 1, 2021

Adding special CSS rules that turn the text lighter only when in dark
mode.

Currently, the website doesn't have a good color contrast while in darkmode.
before

This PR fixes the color in darkmode.
after

(More text is fixed at the bottom of the website in the same way that is shown in the pictures).

Adding special CSS rules that turn the text lighter only when in dark
mode.
@elyassaf
Copy link
Author

elyassaf commented Oct 1, 2021

Sorry, I see now that issue #53 talks about it and that it was assigned to a different person.
Should I close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant