feat(textarea): remove redundant props #6735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: removed cols, size and tooltipMessage props from the TextArea component as they were no longer doing anything fix #6107
edleeks87
approved these changes
May 22, 2024
Parsium
approved these changes
May 22, 2024
stephenogorman
approved these changes
May 24, 2024
|
🎉 This PR is included in version 136.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
BREAKING CHANGE: removed cols, size and tooltipMessage props from the TextArea
component as they were no longer doing anything
fix #6107
Current behaviour
Textarea has a some props that are redundant now and should be removed
Checklist
QA
Additional context
size,colsandtooltipMessageprops have been removed so need to ensure there is no regression