Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(switch): visual overflow with longer translation strings (FE-6374) #6613

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nicktitchmarsh
Copy link
Contributor

Fixes FE-6374

Proposed behaviour

Switch should adapt to varying string lengths

Current behaviour

Longer translation strings cause text to overflow due to fixed width of switch component

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

Run the storybook instance
Edit the pl-pl.ts file to make the translations longer
Set the locale in the docs page.

Copy link
Contributor

@edleeks87 edleeks87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be useful to include a test story that demonstrates what these changes were trying to address. Wrt the rest of my comments, I'm happy to have all that addressed in a separate ticket if this is time sensitive

@nicktitchmarsh nicktitchmarsh requested a review from a team as a code owner April 18, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants