Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heatmap from pre-analyzed moves #809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevinsung
Copy link

Part of #487 .

This lets Sabaki recognize the non-standard SGF properties VISITS, WINRATE, and SCORELEAD in order to draw a heatmap even with no engine analysis session running. Values from a running engine analysis session would override the values from the SGF.

I assumed the following definitions for these properties, but I can change them:

  • VISITS: number of visits
  • WINRATE: probability of black winning as a float in [0, 1]
  • SCORELEAD: number of points black is winning by

The diff is deceptively large because I indented an existing block by an additional level.

I have written a script that uses KataGo to add these properties to an SGF file: https://github.com/kevinsung/katago-analyze-sgf.

Screenshot:
Screenshot from 2021-08-07 14-57-46

@yishn
Copy link
Member

yishn commented Sep 16, 2021

I don't like the non-standard SGF properties. Is anyone else using these? 🤔 I did intend for the heat map to be a fleeting (temporary) board layer as opposed to persisted in the SGF file. But more people do full-game analysis beforehand and want to look at the results. Maybe sync with @pnprog.

@kevinsung
Copy link
Author

Yeah, for better or worse, using non-standard SGF properties is the most straightforward way to support full-game analysis. I did reach out to @pnprog at #487 but he hasn't responded. I would also love to know if other tools use similar non-standard properties; I couldn't find any besides @pnprog's Go Review Partner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants