Integrate NVIDIA's Stdexec impl into HPX #6431

isidorostsa · 2024-02-03T18:33:28Z

No description provided.

CMakeLists.txt

cmake/FindStdexec.cmake

cmake/HPX_SetupStdexec.cmake

libs/CMakeLists.txt

libs/core/execution_base/CMakeLists.txt

codacy-production · 2024-03-11T22:39:09Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -85.23%	✅ 0.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`9c53b99`)	206733	176197	85.23%
Head commit (`2158c81`)	112922 (-93811)	0 (-176197)	0.00% (-85.23%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#6431)	41	0	0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more}

- Completion signatures are a specialization of stdexec::completion_signatures<...> - Senders/Receivers need the is_sender/is_receiver tag - Sender_of<snd, tag> looks for completion signatues (e.g. tag = set_error(std::exception_ptr)) instead of looking for possible set_value(...) specializations

make_env<tag>(val, old_env) The new calling convention for make_env is: make_env(old_env, with(tag, val))

…not working. The rest of the tests pass.

hkaiser

First batch of comments... more to come.

hkaiser · 2024-05-18T14:53:13Z

libs/core/execution/include/hpx/execution/algorithms/let_stopped.hpp

@@ -8,6 +8,9 @@
 #pragma once

 #include <hpx/config.hpp>
+#ifdef HPX_HAVE_STDEXEC
+#else


Missing #include <hpx/execution_base/stdexec_forward.hpp>?

ah yes, thanks!

hkaiser · 2024-05-18T14:54:05Z

libs/core/execution/include/hpx/execution/algorithms/detail/partial_algorithm.hpp

+#ifdef HPX_HAVE_STDEXEC
+            auto scheduler =
+                hpx::execution::experimental::get_completion_scheduler<
+                    hpx::execution::experimental::set_value_t>(
+                    hpx::execution::experimental::get_env(u));
+#else
            auto scheduler =
                hpx::execution::experimental::get_completion_scheduler<
                    hpx::execution::experimental::set_value_t>(u);
+#endif


I think we could factor out this difference allowing for the diferences to be very localized.

We would have to alter our existing senders to provide environments, currently most of the times they do not.

Really? What about:

inline constexpr struct get_completion_scheduler_ex_t { template <typename U> decltype(auto) operator()(U&& u) const { #ifdef HPX_HAVE_STDEXEC return hpx::execution::experimental::get_completion_scheduler< hpx::execution::experimental::set_value_t>( hpx::execution::experimental::get_env(HPX_FORWARD(U, u))); #else return hpx::execution::experimental::get_completion_scheduler< hpx::execution::experimental::set_value_t>(HPX_FORWARD(U, u)); #endif } } get_completion_scheduler_ex{};

Ah yes, good point. I will get on that, and I will migrate to using it after sorting out the build system.

libs/core/algorithms/tests/unit/algorithms/adjacentdifference_tests.hpp

libs/core/execution/include/hpx/execution/algorithms/as_sender.hpp

libs/core/execution/include/hpx/execution/queries/read.hpp

hkaiser · 2024-05-18T15:04:28Z

libs/core/execution/tests/unit/algorithm_as_sender.cpp

        static_assert(ex::is_sender_v<decltype(s), ex::empty_env>);
+#endif


Shouldn't we rather implement is_sender_in_v for our code base?

right, leaving that as a TODO to remove much of the duplication from the tests.

…nvoke

isidorostsa requested a review from hkaiser as a code owner February 3, 2024 18:33

isidorostsa marked this pull request as draft February 3, 2024 18:33

hkaiser added type: enhancement type: compatibility issue category: executors labels Feb 3, 2024

hkaiser reviewed Feb 3, 2024

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

isidorostsa force-pushed the include_stdexec branch from 8826f04 to 634cb7b Compare February 6, 2024 14:38

Add Stdexec to the build system

1798cbc

isidorostsa force-pushed the include_stdexec branch from 634cb7b to 1798cbc Compare February 8, 2024 15:33

hkaiser reviewed Feb 12, 2024

View reviewed changes

isidorostsa force-pushed the include_stdexec branch from 6ec03fa to 5b5ac33 Compare February 15, 2024 16:59

link against hpx_core

f34103e

isidorostsa force-pushed the include_stdexec branch from 5b5ac33 to f34103e Compare February 15, 2024 17:56

isidorostsa added 3 commits February 17, 2024 17:40

move code to HPX_SetupStdexec

cc03efd

recognize STDEXEC & Stdexec

3e5bee6

added pika's changes

3abc290

isidorostsa added 10 commits March 14, 2024 17:31

Re-added removed functionallities + more forwards

45dbae6

trying to pass any_sender tests

1e2fa72

The old calling convention is:

764add3

make_env<tag>(val, old_env) The new calling convention for make_env is: make_env(old_env, with(tag, val))

Forwarding implementations

4def4cf

The ensure_started algorithm needed for specific any_sender tests is …

bddfdc7

…not working. The rest of the tests pass.

Incomplete tests

746ea02

Typo

a06621f

More fixes

4964016

heavily modified run_loop test

59b5170

isidorostsa force-pushed the include_stdexec branch from 9c0318f to 59b5170 Compare April 24, 2024 18:09

Multiple test fixes

39cee7b

isidorostsa force-pushed the include_stdexec branch from 36bfaf7 to 39cee7b Compare May 10, 2024 19:29

isidorostsa added 7 commits May 14, 2024 13:22

many more test fixes

59b9571

fix algorithm tests syntax

2897d3e

thread_pool, bulk to spec

53ce2ec

use when_all | then instead of dataflow in rotate.hpp

20094d3

make future that starts run loop (tbd)

e8ebb48

flyby fix for meta, pack

e253726

mass clang/cmake format

b111ca7

hkaiser reviewed May 18, 2024

View reviewed changes

detect comp sched with concept, bypass stdexec's internal weird tag i…

210ddea

…nvoke

isidorostsa force-pushed the include_stdexec branch from 1f90be4 to 210ddea Compare May 21, 2024 17:47

isidorostsa added 10 commits May 22, 2024 12:58

address comments

3efa245

Restrict stdexec forward to not include everything.

c1ea22f

Fetch STDEXEC

222845f

Fix scheduler_and_policy to be a scheduler under p2300

a91b8d5

Make sure futures take the future path instead of the sender

a33c3c8

format

3e51d4b

HPX_WITH_STDEXEC on by default for cpp20

5bb5788

Revert rotate.hpp accidental delete

40285e1

correct default fetching on cpp20

74c1d13

spellcheck

2158c81

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate NVIDIA's Stdexec impl into HPX #6431

Integrate NVIDIA's Stdexec impl into HPX #6431

isidorostsa commented Feb 3, 2024

codacy-production bot commented Mar 11, 2024 •

edited

hkaiser left a comment

hkaiser May 18, 2024

isidorostsa May 21, 2024

hkaiser May 18, 2024

isidorostsa May 21, 2024

hkaiser May 21, 2024

isidorostsa May 22, 2024

hkaiser May 18, 2024

isidorostsa May 21, 2024

		static_assert(ex::is_sender_v<decltype(s), ex::empty_env>);
		#endif

Integrate NVIDIA's Stdexec impl into HPX #6431

Are you sure you want to change the base?

Integrate NVIDIA's Stdexec impl into HPX #6431

Conversation

isidorostsa commented Feb 3, 2024

codacy-production bot commented Mar 11, 2024 • edited

Coverage summary from Codacy

hkaiser left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codacy-production bot commented Mar 11, 2024 •

edited