Lots of scaffolding, a bit of UI #46

regexpressyourself · 2017-02-28T17:29:58Z

This pull request includes:

A webpack setup that enables ES6 goodness in react
- You will need to install some npm modules to compile react. From the project root, run npm install (make sure you have npm on your machine...)
- If you edit any components, be sure to run "webpack" from the project root to compile them
  - React components are compiled down into the /wwwroot/js/build folder
Add a link to the Create page on the nav
Add a "Add Step" button to the Edit page
- Clicking the "Add Step" button brings up a modal with a form for the step
- Form currently does not submit to anything
Add a css file to start using (main.css)
- Might end up using the site.css file instead

Create page now only prompts for flowchart name. The first two react components are added. I need to add a loader for them to allow for composition of components. I think webpack is the best bet here.

Tested functionality, it works.

Cleaned up the code a bit.

git blame visual studio

Using the CDN in _Layout instead

Form currently does not submit to anything.

regexpressyourself · 2017-02-28T21:01:25Z

@taylorflatt @Mikey1848 @reidtevonian

Got a lot added here. I did a test merge with master and it looked conflict free, but I wanted to give you guys a heads up before it all gets merged in. If you guys want to merge it in, that works great. If not, I'll merge it in tonight.

taylorflatt · 2017-02-28T21:19:27Z

Flowchart/Controllers/FlowchartController.cs


 namespace FlowchartCreator.Controllers
 {
+    // DEBUG: Comment/Uncomment this to require authentication to access this controller's components.
+    [Authorize]


Probably want to comment this out before pushing to the master branch. I might have missed it.

Fixed 9a3a227

I just meant to comment it out not remove it. But either way works.

Oops. Fixed Fixed 3ac35d6

taylorflatt · 2017-02-28T21:20:31Z

Flowchart/obj/Debug/netcoreapp1.0/FlowchartCreator.csproj.FileListAbsolute.txt

@@ -8,3 +8,23 @@ C:\Users\Taylor\Source\Repos\Flowchart-Creator-production\Flowchart\obj\Debug\ne
 C:\Users\Taylor\Source\Repos\Flowchart-Creator-production\Flowchart\obj\Debug\netcoreapp1.0\FlowchartCreator.pdb
 C:\Users\Taylor\Source\Repos\Flowchart-Creator-production\Flowchart\obj\Debug\netcoreapp1.0\UserSecretsAssemblyInfo.cs
 C:\Users\Taylor\Source\Repos\Flowchart-Creator-production\Flowchart\obj\Debug\netcoreapp1.0\FlowchartCreator.csprojResolveAssemblyReference.cache
+C:\Users\Sam\Desktop\Flowchart-Creator-production\Flowchart\bin\Debug\netcoreapp1.0\FlowchartCreator.deps.json


Shouldn't these be excluded and purged from master? Similar for other references specific to the dev env.

Yeah I think so, but I didn't want to mess anything up for anyone else. Is there anything in the netcoreapp1.0 folder that we would need? Ca I just ignore the whole thing?

I don't have it in front of me but you could just try deleting it and running the project. My guess is that it will be generated if it doesn't already exist. I never used to have this prior to .NET Core.

Coolio. I saw this post that says I can just kill off the entire bin and obj directories in git, so I did that. Woo!!

See 016b235 for specifics

taylorflatt · 2017-02-28T21:24:35Z

@regexpressyourself Can you clear up some ignorance on my part? Is there a reason the client/server is so large and why we need both? I thought you were mentioning that we should be running these on the server side. So shouldn't the server bundle be the only one included?

regexpressyourself · 2017-02-28T21:46:07Z

@regexpressyourself Can you clear up some ignorance on my part? Is there a reason the client/server is so large and why we need both? I thought you were mentioning that we should be running these on the server side. So shouldn't the server bundle be the only one included?

@taylorflatt Don't worry, you're not the only ignorant one here :)

I'm not 100% sure how to run them server side just yet. Technically we could get by with only the client side, as that is all that's being run, but I want to include the scaffolding for server side rendering later.

Server side will help performance in production, but is a pain to use when in development because I would have to rebuild the project to test changes (I think...again not 100% on this stuff yet).

As for why we have both, we can choose to render some components on the server and some on the client as we see fit. Mostly static components can be rendered server-side, and more dynamic components can be rendered client side.

Concerning the size, I'm not sure why they're so big. I know I can minify them, but that doesn't reduce the code size, just the file size. They're being rendered by Babel; I can look into some options to make it more streamlined.

taylorflatt · 2017-02-28T22:14:27Z

@regexpressyourself That's fine. I don't mind doing it either way. Which plan do you think you are going to pursue? Combination? Client only?

regexpressyourself · 2017-02-28T22:26:45Z

@taylorflatt Ideally, I'd like to render as much on server side as possible. Whether that will end up being everything or not, I'm not sure. Regardless, I think it's a problem for sprint 3, since the react stuff should be mostly done before we start adding it to the server.

Re: the file size. I found a thread on the topic. Consensus is basically to minify the code for production.

taylorflatt · 2017-02-28T22:32:29Z

@regexpressyourself No problem. That seems reasonable. I was going to advocate for an either-or approach to minimize code/complexity/size of the solution. Only introduce what we need when we need it so we don't forget to go back and remove the extraneous parts.

But use what you need. I think I am fine with the pull but I think we should still take a look at those other files so they aren't constantly updated.

Trying to keep git from going insane on every build.

regexpressyourself · 2017-02-28T22:46:48Z

we should still take a look at those other files so they aren't constantly updated.

@taylorflatt Agreed!! I just did it. See 016b235 and this

Commiting early to work on seperate machine

Sass was proving difficult to install. Might revisit it later.

regexpressyourself and others added 12 commits February 27, 2017 14:58

added first react components, set up create page

70a00fe

Create page now only prompts for flowchart name. The first two react components are added. I need to add a loader for them to allow for composition of components. I think webpack is the best bet here.

Added user delete.

8e91d9f

Tested functionality, it works.

Added some documentation.

7adec7f

Cleaned up the code a bit.

set up webpack for react files

3d2d233

Merge branch 'tf-sprint1' into sm-sprint1

f7b4432

Not sure what these are, but apparently I changed them

d43afb6

git blame visual studio

Changed Canvas back to dummy text

fa37af8

Moved call to js bundle

9ef8531

Added some config files to gitignore

190ec3b

Added styles and early functionality to new step button

d7fc0e6

Remove react call from webpack

680d9b3

Using the CDN in _Layout instead

Added "New Step" modal on button click

55a6432

Form currently does not submit to anything.

taylorflatt reviewed Feb 28, 2017

View reviewed changes

Got rid of all the crazy visual studio nonsense

016b235

Commented out Authorize instead of deleting it

3ac35d6

regexpressyourself added 3 commits February 28, 2017 17:19

Added ES6 module system to /js/React

c5927c9

Added Create link to nav

850b33f

Added new build for react components

1ccc44f

regexpressyourself added 3 commits February 28, 2017 17:34

added package.json for easy npm installs

422baf6

added some stuff to the gitignore file

d0d4edc

Trying to keep git from going insane on every build.

Added all the crazy visual studio stuff

cce7efe

taylorflatt added this to the Sprint-1 milestone Feb 28, 2017

taylorflatt added the Enhancement label Feb 28, 2017

regexpressyourself added 3 commits February 28, 2017 18:40

Added beginning of sass config

a7da997

Commiting early to work on seperate machine

Remove sass and go with plain old CSS

48c7e2a

Sass was proving difficult to install. Might revisit it later.

added popup modal to canvas component

58752db

regexpressyourself merged commit b681591 into master Mar 1, 2017

regexpressyourself added 2 commits February 28, 2017 21:34

Removed Authorize in Flowchart Controller

9a3a227

Added netcoreapp1.0 to gitignore

262bf64

regexpressyourself mentioned this pull request Mar 1, 2017

Create a Flowchart #13

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lots of scaffolding, a bit of UI #46

Lots of scaffolding, a bit of UI #46

regexpressyourself commented Feb 28, 2017 •

edited

regexpressyourself commented Feb 28, 2017

taylorflatt Feb 28, 2017

regexpressyourself Feb 28, 2017

taylorflatt Feb 28, 2017

regexpressyourself Feb 28, 2017

taylorflatt Feb 28, 2017

regexpressyourself Feb 28, 2017

taylorflatt Feb 28, 2017

regexpressyourself Feb 28, 2017

taylorflatt commented Feb 28, 2017

regexpressyourself commented Feb 28, 2017

taylorflatt commented Feb 28, 2017

regexpressyourself commented Feb 28, 2017

taylorflatt commented Feb 28, 2017

regexpressyourself commented Feb 28, 2017 •

edited

Lots of scaffolding, a bit of UI #46

Lots of scaffolding, a bit of UI #46

Conversation

regexpressyourself commented Feb 28, 2017 • edited

regexpressyourself commented Feb 28, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

taylorflatt commented Feb 28, 2017

regexpressyourself commented Feb 28, 2017

taylorflatt commented Feb 28, 2017

regexpressyourself commented Feb 28, 2017

taylorflatt commented Feb 28, 2017

regexpressyourself commented Feb 28, 2017 • edited

regexpressyourself commented Feb 28, 2017 •

edited

regexpressyourself commented Feb 28, 2017 •

edited