Stop E2E tests from hanging on failure #162566752 #199
Conversation
This commit also upgrades jest and removes use of fake timers
|
Testing for this is checking that
Conveniently, tests are failing everywhere on partners right now 😄 |
| @@ -66,10 +66,8 @@ | |||
| }, | |||
| "scripts": { | |||
| "unit": "jest --testPathPattern=.*.test.js$ --coverage", | |||
| "e2e": "jest --testPathPattern=.*e2e.* --runInBand", | |||
| "e2e": "jest --testPathPattern=.*e2e.* --runInBand. --forceExit", | |||
There was a problem hiding this comment.
adding this forceExit is what caused it to actually exit. I tried using --detectOpenHandles to determine what was wrong (which required the upgrade to 23.x), but it didn't return any results.
Based on comments on jestjs/jest#1456, it seems like it's possible that the issue is not uncommon! and that --runInBand may be the culprit.
I tried running the tests in parallel, but ended up with a lot of salesforce auth errors from trying to sign in at the same time.
This was due to an update made in Jest v23
|
I'm not going to fix the code climate issues, but I am waiting for semaphore job to pass |
|
Code Climate has analyzed commit eb10e62 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 76.8%. View more on Code Climate. |
|
merging despite code climate duplication warnings |
This commit also upgrades jest and removes use of fake timers
Pivotal ticket: https://www.pivotaltracker.com/story/show/162566752
As part of my testing to figure out why tests were hanging, I tried removing use of fake timers, which closes out this ticket too: https://www.pivotaltracker.com/story/show/162182016