Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add emotion text emotion api #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add emotion text emotion api #6

wants to merge 3 commits into from

Conversation

viveknimkarde
Copy link
Contributor

  • Add Text Emotion API wrapper for python

sushant-hiray
sushant-hiray requested changes Jun 21, 2018
View reviewed changes
test/test_text_recoginse_emotion.py Outdated
@@ -0,0 +1,52 @@
# coding: utf-8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in file name

test/test_text_recoginse_emotion.py Outdated
import uuid


class TestTextEmootion(unittest.TestCase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in class name

test/test_text_recoginse_emotion.py Outdated

def setUp(self):
deepaffects.configuration.api_key['apikey'] = os.environ['DEEPAFFECTS_API_KEY']
self.webhook_url = os.environ["DEEPAFFECTS_API_WEBHOOK"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use consistent quotes

test/test_text_recoginse_emotion.py Outdated
def tearDown(self):
pass

def test_async_diarize_audio(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you aren't testing diarize audio here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more tests to test the cases where the request is malformed. Also check for all the expected keys in output

@viveknimkarde viveknimkarde force-pushed the add-text-emotion-api branch 2 times, most recently from 217cd50 to 8890efd Compare June 21, 2018 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushant-hiray sushant-hiray sushant-hiray requested changes

@toyokazu03102478 toyokazu03102478 toyokazu03102478 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@viveknimkarde @sushant-hiray @toyokazu03102478