Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update portfolio summary #4666

Merged
merged 20 commits into from
May 17, 2024
Merged

Update portfolio summary #4666

merged 20 commits into from
May 17, 2024

Conversation

perryr16
Copy link
Contributor

@perryr16 perryr16 commented May 9, 2024 •
edited

Any background context you want to provide?

User requested updates

What's this PR do?

  • Adds new Goal.commitment_sqft field
  • Adds total properties and commitment to goal details gray box
  • Adds a goal stats table with Commitment Sq Ft, Shared Sq Ft, Passing Checks Sq Ft, Passing Checks % of Committed, Passing Checks % of Shared, Total Passing Checks, Total New or Acquired
  • Added ui-grid actions dropdown featuring ability to Select All, Select None, Add/Remove Labels, Bulk Edit Goal Notes, Show/Hide Access Levels
  • New Modal for bulk editing GoalNotes
  • Creates GoalNotes for newly imported properties

How should this be manually tested?

Confirm the following

  • Commitment Sq Ft = user input
  • Shared Sq Ft = total sqft
  • Passing Checks Sq Ft = total sqft of properties with passing checks
  • Percentages are accurate
  • Totals are accurate
  • Portfolio Summary values are only calculated with properties passing checks and not new or acquires
  • Actions - Add/Remove Labels
  • Actions - Bulk edit selected goal notes (blank is a valid input as long as the field is selected)

What are the relevant tickets?

#4661

Screenshots (if appropriate)

Screenshot 2024-05-10 at 2 15 22 PM

Screenshot 2024-05-10 at 2 15 30 PM
Screenshot 2024-05-10 at 2 17 11 PM

@perryr16 perryr16 added the Feature Add this label to new features. This will be reflected in the change log when generated. label May 9, 2024
@perryr16 perryr16 changed the title 4661 portfolio summary updates Update portfolio summary May 10, 2024
@perryr16 perryr16 marked this pull request as ready for review May 13, 2024 14:49
@perryr16 perryr16 requested a review from kflemin May 13, 2024 14:49
kflemin
kflemin approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@axelstudios axelstudios merged commit f5fc3b7 into develop May 17, 2024
9 checks passed
@axelstudios axelstudios deleted the 4661-portfolio-summary-updates branch May 17, 2024 21:28
perryr16 added a commit that referenced this pull request May 21, 2024
@perryr16 @kflemin
Update portfolio summary (#4666)
e7972c0 
* new stats table

* commitment sqft added to goal

* actions to  goal stats table

* stats table, actions dropdown

* stats, create goal_notes for newly uploaded properties

* add current cycle property ids to goal get

* actions dropdown and base for bulk goalnote edit

* bulk update goalnote

* bulk update historical note

* rename

* precommit

* permissions and tests

* lint

* permission refactor

* permission refactor

* lint

* phrasing

* small language update and added translations

---------

Co-authored-by: kflemin <2205659+kflemin@users.noreply.github.com>
haneslinger pushed a commit that referenced this pull request May 21, 2024
@perryr16 @kflemin @haneslinger
Update portfolio summary (#4666)
c59fe35 
* new stats table

* commitment sqft added to goal

* actions to  goal stats table

* stats table, actions dropdown

* stats, create goal_notes for newly uploaded properties

* add current cycle property ids to goal get

* actions dropdown and base for bulk goalnote edit

* bulk update goalnote

* bulk update historical note

* rename

* precommit

* permissions and tests

* lint

* permission refactor

* permission refactor

* lint

* phrasing

* small language update and added translations

---------

Co-authored-by: kflemin <2205659+kflemin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kflemin kflemin kflemin approved these changes

Assignees
No one assigned
Labels
Feature Add this label to new features. This will be reflected in the change log when generated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@perryr16 @kflemin @axelstudios