Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to match and merge cycle properties #4660

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

perryr16
Copy link
Contributor

@perryr16 perryr16 commented May 6, 2024

Any background context you want to provide?

With the introduction of UBID thresholds as an organization setting, there should be an option to trigger matching and merging following a UBID threshold change.

What's this PR do?

  • adds button to trigger matching and merging using existing functionality from /data_importer/match.py
  • adds modal to track progress

How should this be manually tested?

  • make UBID threshold strict (1.0)
  • upload a file that has properties with matching PM property IDs, and overlapping (not identical) UBIDs.
  • make UBID threshold loose (0.1)
  • click Trigger Matching and Merging
  • Properties with overlapping UBIDs should have been merged (assuming jaccard index was greater than UBID threshold)

What are the relevant tickets?

#4615

Screenshots (if appropriate)

Screenshot 2024-05-06 at 9 39 08 AM
Screenshot 2024-05-06 at 10 37 56 AM

@perryr16 perryr16 added the Feature Add this label to new features. This will be reflected in the change log when generated. label May 6, 2024
@perryr16 perryr16 changed the title 4615 ubid matching button Add button to match and merge cycle properties May 6, 2024
@perryr16 perryr16 marked this pull request as ready for review May 6, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Add this label to new features. This will be reflected in the change log when generated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant