Coop coordination #280
Draft
Coop coordination #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an optional key to the dictionary input of COOP calculation that includes the coordination number to be considered for each of the two elements
felipeZ
requested changes
Sep 11, 2020
| from qmflows.parsers.xyzParser import readXYZ | ||
|
|
||
| from nanoCAT.recipes import coordination_number |
There was a problem hiding this comment.
nanoCAT must be included in the library requirements at setup.py
|
@juliette1996 Could you please provide a description of what is the purpose of this PR? |
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
==========================================
- Coverage 83.23% 82.84% -0.40%
==========================================
Files 23 23
Lines 1563 1574 +11
Branches 194 198 +4
==========================================
+ Hits 1301 1304 +3
- Misses 209 215 +6
- Partials 53 55 +2
Continue to review full report at Codecov.
|
BvB93
reviewed
Sep 14, 2020
| element_2_index = [i for i, s in enumerate(mol) if element_2.lower() in s] | ||
|
|
||
| # For the two selected elements, only the indices corresponding to a given coordination number | ||
| else: |
There was a problem hiding this comment.
Fyi, you can also make nano-CAT an optional dependency and then raise any potential ImportErrors whenever a code branch is reached that does require nano-CAT:
from typing import Optional
try:
from nanoCAT import coordination_number
NANOCAT_EX: Optional[ImportError] = None
except ImportError as ex:
NANOCAT_EX = ex
def compute_overlap_and_atomic_orbitals(...):
if config["elements_coordination"] is None:
...
elif NANOCAT_EX is not None:
raise NANOCAT_EX
else:
coord = coordination_number(geometry)
...
|
Hi @juliette1996 is there any update in this PR? :) |
BvB93
force-pushed
the
master
branch
8 times, most recently
from
4e68969
to
6830e71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.