Mesh distance symmetric #2041
Open
Mesh distance symmetric #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akenmorris
requested changes
Apr 21, 2023
| auto field = m.distance(m2)[0]; | ||
| auto field = m.distance(m2, Mesh::DistanceMethod::SymmetricPointToCell)[0]; | ||
| // TODO: disable debug | ||
| std::cout << "Debug Mode | Computing distance with SymmetricPointToCell method in Studio Viewer " << std::endl; |
There was a problem hiding this comment.
K, let's remove this debug line and I think it's good to go.
| referenceMesh (point) -> targetMesh (cell) (and get closestPoint) | ||
| referenceMesh (cell) -> targetMesh (closestPoint) | ||
| */ | ||
| auto targetCellLocator = vtkSmartPointer<vtkCellLocator>::New(); |
There was a problem hiding this comment.
use the faster vtkStaticCellLocator
| targetCellLocator->SetDataSet(target.poly_data_); | ||
| targetCellLocator->BuildLocator(); | ||
|
|
||
| auto refCellLocator = vtkSmartPointer<vtkCellLocator>::New(); |
There was a problem hiding this comment.
vtkStaticCellLocator as above
|
Hello, I propose also to add the signed point-to-cell metric, I will amend the commit |
ben2k
reviewed
Apr 26, 2023
| @@ -556,6 +556,42 @@ std::vector<Field> Mesh::distance(const Mesh& target, const DistanceMethod metho | |||
| } | |||
| } break; | |||
|
|
|||
| case SymmetricPointToCell: { | |||
There was a problem hiding this comment.
Missing a unit test for that case ?
|
@nawazishkhan1-nk , do you have an update on the PR? |
|
@nawazishkhan1-nk , any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] - Do Not Merge
Summary
This PR addresses issue #2040.
Changes Made
Testing Done
Known Issues
Screenshots
Symmetric Point-to-cell distance vs. regular Point-to-cell distance
