New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Case Documentation #1472
Use Case Documentation #1472
Conversation
Can we please link all the related issues to the PR? (Button at bottom of right hand column, "linked issues".) In particular #1103 is linked to lots of other issues. Are these all taken care of with this PR? |
I have compiled and am reviewing the documentation. It might help to update this section in order for reviewing to be inline with the instructions for doing so: http://sciinstitute.github.io/ShapeWorks/dev/docs.html. |
Issue #1103 is linked to all of the use case issues but this PR just
addresses the documentation, the use case issues will not be closed with
this PR.
I believe the two issues I linked are the only relevant ones.
…On Mon, Sep 20, 2021 at 1:19 PM Cameron Christensen < ***@***.***> wrote:
Can we please link all the related issues to the PR? In particular #1103
<#1103> is linked to
lots of other issues. Are these all taken care of with this PR?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1472 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM65AFOJII35AN2AFWYNQZTUC6CKNANCNFSM5EFE6HYA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
There are some missing resources, including simple gifs found on the SCI server (see #1470 (comment)). Other resource found on the sci server are found just fine. |
Here are lots of details and suggestions, starting with...
[] better organization of general overview page
[] specific pages...
...getting overwhelmed with too much of the same; need to break up organization of cases [] overall organization of specific pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment on issue.
Steps moving forward:
|
Use Cases:
|
…n_cavity_bean, ellipsoid_mesh, deep_smm
…Works into documents_6.2
Wow! This is so much more understandable and worthwhile to users.
So a couple small changes, maybe some additional issues (so we don't forget), and merge! |
No it still automatically downloads. We are just noting that the data was generated by running the femur use case |
For all the mesh use cases, grooming will be added in the next release. Right now they run on pre-groomed data.
Created: #1492 |
Can this be made more clear in the documentation? All that needs to be added, probably to the data section early on, is what you just wrote. Thanks! |
Will you please add a note to the beginning of the issue that clarifies this for the user? Thank you. |
I am unclear on this use case... Looks like Archana added the documentation. |
All of Cameron's suggested changes have been made. The right ventricle use case does not show up in the web doc (it's not in the yml) so I think it is okay to leave it. I also added the note about windows visualization to the notebooks for issue #1113 Should be ready to merge! |
This PR makes the use case documentation uniform and removes a lot of repetition. All of the copy and pasted documentation that was the same for every use case is now only in "Getting Started with Use Cases" file (use-cases.md).
Addresses issues #1103 and #1347.
Each md file now contains the following sections:
To review this PR you need to checkout the branch and run
mkdocs serve
. The videos on the sci server will not be visible via the github web interface.