Simplify build system and add python as dependency #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CFLAGS and CXXFLAGS env. variables are explicitly set in travis configuration Explicit passing of "-Wno-deprecated" to ITK project is removed because (1) it is done starting with ITK project 4.0 in InsightSoftwareConsortium/ITK@8a135bcb1 (ENH: Detect/use recommended compiler flags) from 2011-08-20 and (2) Seg3D is build against ITK 5.x. See 3b6512c (Update ITK version to 5.1.0)
jcfr
force-pushed
the
simplify-build-system-and-add-python-as-dependency
branch
from
70f2c35
to
3174523
Compare
Since TravisCI seems to now offers a finite amount of "credits" for open source projects, this commit removes the corresponding support. See https://travis-ci.community/t/question-open-source-travis-ci-for-open-source-projects-as-of-august-2022/13233
jcfr
force-pushed
the
simplify-build-system-and-add-python-as-dependency
branch
from
cfcf22f
to
1fc9377
Compare
… Qt 5.15.2 All: * Standardize on using Qt 5.15.2 * Split configure command across multiple lines Linux: * Update runner from "ubuntu-18.04" to "ubuntu-20.04" macOS: * Hard-code runner to "macos-10.15" Windows: * Update runner from "windows-2016" to "windows-2022" * Update Visual Studio from "15 2017" to "17 2022" * Explicitly specify toolset v143
jcfr
force-pushed
the
simplify-build-system-and-add-python-as-dependency
branch
from
1fc9377
to
cb23254
Compare
dcwhite
reviewed
Mar 15, 2023
| include: | ||
| - qtversion: 5.15.2 | ||
| qtarch: win64_msvc2019_64 | ||
| cmake-generator: "Visual Studio 17 2022" |
There was a problem hiding this comment.
I think this will require updating the Boost dependency to something newer, and possibly python as well. It might break a lot of code. I have SCIRun building with Boost 1.75, but that version is also too old for VS 2022.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.