Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better font rendering on OSX #353

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Better font rendering on OSX #353

wants to merge 13 commits into from

Conversation

allywarner
Copy link
Contributor

Fixes widgets being squished as well on OSX.

@allywarner
Copy link
Contributor Author

Closes #349 and hopefully #132, but Windows still has squished widgets on high resolution monitors.

@dcwhite
Copy link
Member

dcwhite commented Jun 23, 2020

I made a build and an installer and didn't notice a change. Qt 5.14/MacOS 10.14. I deleted all from Superbuild down. Do I need to blow everything away? I'll try one more time.

image

@allywarner allywarner self-assigned this Jul 7, 2020
@allywarner allywarner added this to the v. 2.5.x milestone Jul 7, 2020
@allywarner allywarner marked this pull request as draft July 8, 2020 19:48
@jessdtate
Copy link
Contributor

even after a fresh build, doesn't seem to do anything to the fonts

@dcwhite
Copy link
Member

dcwhite commented Jul 14, 2020

Alan 3:52 PM
One thing that you have to keep in mind is that OSX now caches plist files, and if you just edit it for a .app, you won't see any change.

You can force it with a "defaults read /path/to/plist" as I recall.

Another thing you can do is copy it to a new location.

This has confused me many times.

@dcwhite
Copy link
Member

dcwhite commented Jul 14, 2020

@allywarner If we can get this one to work, it should be merged before the version update, yeah?

@allywarner
Copy link
Contributor Author

@dcwhite I think so! It'd be a nice addition.

@dcwhite
Copy link
Member

dcwhite commented Jul 16, 2020

I think the problem is the actual bundle plist file is not getting this change. I'll check the cpack code

@dcwhite
Copy link
Member

dcwhite commented Jul 16, 2020

Yes, there are deeper problems here. The plist file that winds up in the bundle is hard-coded and located in src/Resources/. So that one would get the NSHighResolutionCapable key addition. There are two .plist.in files in the CMake/Modules directory, and they're both ignored (and both are a mess of duplicated keys it seems). So this needs more clean up. I'll investigate more tomorrow.

@dcwhite
Copy link
Member

dcwhite commented Jul 21, 2020

@jessdtate We figured out how to get improved font rendering (make the same small change, but to a different plist file) but uncovered some sloppy messiness related to the plist files in the repo. Should we (a) clean up the messiness now or (b) make the quick fix to get the fonts working before the release?

@jessdtate
Copy link
Contributor

let's fix it in the next release. I think we are ready to go otherwise.

@allywarner allywarner modified the milestones: v. 2.5.x, 2.5.1 Aug 6, 2020
There should only be one plist file.
Not sure if this will make a change.
add NS principal class
@allywarner allywarner modified the milestones: 2.5.1, 2.5.2 May 21, 2021
@dcwhite dcwhite removed their request for review June 29, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants