Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with Local Ospray #2430

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

tarkpate
Copy link
Contributor

I added a CMake flag that searches for a prebuilt version of OSPRay. You just download and add the directory to the path. Also added instructions in the doc.

@tarkpate
Copy link
Contributor Author

I made this change so I can use a local build of OSPRay so I can edit and recompile separately, but it looks like it works with prebuilt binaries. We may be able to use this to replace the default action of compiling OSPRay from scratch with just a simple binary download and link. We also wouldn't need to fork and edit for each version release.

@dcwhite
Copy link
Member

dcwhite commented Jul 18, 2023

This would be very useful.

@@ -46,7 +46,7 @@ using namespace Render;
using namespace Core::Datatypes;
using namespace Core::Geometry;

#ifdef WITH_OSPRAY
#if defined(WITH_OSPRAY) || defined(WITH_OSPRAY_LOCAL)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you define this disjunction in CMake? Then no C++ files need to change.

WITH_OSPRAY --> BUILD_OSPRAY
WITH_OSPRAY_LOCAL --> PREBUILT_OSPRAY
Then add cmake for WITH_OSPRAY = BUILD_OSPRAY || PREBUILT_OSPRAY
A few cmake files will need to change, but no C++

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I'll get this changed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarkpate I could handle this change if you are too busy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updated with these new flags

@dcwhite dcwhite added this to the 5.0.0 milestone Sep 20, 2023
@tarkpate tarkpate marked this pull request as ready for review October 31, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants