Add missing lock on texture cache UpdateMapping method #6657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AcK77
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UpdateMappingmethod removes and adds a new texture, so it must take a look for the textures tree, since it might be accessed by another thread (for example, onMemoryUnmappedHandlermethod).This additionally refactors the lock usage to instead use a
ReaderWriterLockSlim, which allows concurrent access to the tree and should be more efficient than the regular lock (which would block on concurrent access).This fixes a crash on the game Harmony: The Fall of Reverie. Other games might be affected as well.
The crash happens upon entering this place called "the Naiads".