release: 0.9.4

manifest.json

@@ -1,7 +1,7 @@
 {
     "id": "pdf-plus",
     "name": "PDF++",
-    "version": "0.9.3",
+    "version": "0.9.4",
     "minAppVersion": "1.3.5",
     "description": "Enhance PDF viewer & embeds.",
     "author": "Ryota Ushio",

package.json

@@ -1,6 +1,6 @@
 {
     "name": "obsidian-pdf-plus",
-    "version": "0.9.3",
+    "version": "0.9.4",
     "description": "An Obsidian.md plugin to enhance PDF viewer & embeds.",
     "scripts": {
         "dev": "node esbuild.config.mjs",

src/color-palette.ts

@@ -14,11 +14,15 @@ export class ColorPalette {
 
     constructor(public plugin: PDFPlus, toolbarLeftEl: HTMLElement) {
         this.app = plugin.app;
-        plugin.registerEl(toolbarLeftEl.createDiv('pdf-toolbar-spacer'));
-        this.paletteEl = plugin.registerEl(toolbarLeftEl.createEl('div', { cls: ColorPalette.CLS }));
         this.itemEls = [];
         this.action = plugin.settings.defaultColorPaletteAction;
 
+        if (!plugin.settings.colorPaletteInEmbedToolbar && toolbarLeftEl.closest('.pdf-embed')) return;
+
+        plugin.registerEl(toolbarLeftEl.createDiv('pdf-toolbar-spacer'));
+        this.paletteEl = plugin.registerEl(toolbarLeftEl.createEl('div', { cls: ColorPalette.CLS }));
+
+
         for (const [name, color] of Object.entries(plugin.settings.colors)) {
             if (!isHexString(color)) continue;
 

src/patch.ts

@@ -125,7 +125,8 @@ export const patchPDF = (plugin: PDFPlus): boolean => {
         reset(old) {
             return function () {
                 const self = this as PDFToolbar;
-                new ColorPalette(plugin, self.toolbarLeftEl);
+                // without setTimeout, the colorPaletteInEmbedToolbar option doesn't work for newly opened notes with PDF embeds
+                setTimeout(() => new ColorPalette(plugin, self.toolbarLeftEl));
                 old.call(this);
             }
         }

src/settings.ts

@@ -39,6 +39,7 @@ export interface PDFPlusSettings {
 	colors: Record<string, HexString>;
 	defaultColor: string;
 	colorPaletteInToolbar: boolean;
+	colorPaletteInEmbedToolbar: boolean;
 	highlightColorSpecifiedOnly: boolean;
 	doubleClickHighlightToOpenBacklink: boolean;
 	hoverHighlightAction: keyof typeof HOVER_HIGHLIGHT_ACTIONS;
@@ -69,6 +70,7 @@ export const DEFAULT_SETTINGS: PDFPlusSettings = {
 	},
 	defaultColor: '',
 	colorPaletteInToolbar: true,
+	colorPaletteInEmbedToolbar: false,
 	highlightColorSpecifiedOnly: false,
 	doubleClickHighlightToOpenBacklink: true,
 	hoverHighlightAction: 'open',
@@ -329,12 +331,19 @@ export class PDFPlusSettingTab extends PluginSettingTab {
 					dropdown.selectEl.id = 'pdf-plus-default-color-dropdown';
 				})
 		}
-		this.addToggleSetting('colorPaletteInToolbar')
+		this.addToggleSetting('colorPaletteInToolbar', () => {
+			this.redisplay();
+			this.plugin.loadStyle();
+		})
 			.setName('Show color palette in the toolbar')
 			.setDesc('A color palette will be added to the toolbar of the PDF viewer. Clicking a color while selecting a range of text will copy a link to the selection with "&color=..." appended.');
-		this.addDropdowenSetting('defaultColorPaletteAction', COLOR_PALETTE_ACTIONS)
-			.setName('Default action when clicking on a color palette item')
-			.setDesc('You can change it for each viewer with the dropdown menu in the color palette.')
+		if (this.plugin.settings.colorPaletteInToolbar) {
+			this.addToggleSetting('colorPaletteInEmbedToolbar', () => this.plugin.loadStyle())
+				.setName('Show color palette for PDF embeds as well');
+			this.addDropdowenSetting('defaultColorPaletteAction', COLOR_PALETTE_ACTIONS)
+				.setName('Default action when clicking on a color palette item')
+				.setDesc('You can change it for each viewer with the dropdown menu in the color palette.')
+		}
 
 		this.addHeading('Opening links to PDF files');
 		this.addToggleSetting('openLinkCleverly', () => this.redisplay())