release: 0.38.0

RyotaUshio · Mar 17, 2024 · 1070dbc · 1070dbc
1 parent 66b335b
commit 1070dbc
Show file tree

Hide file tree

Showing 27 changed files with 764 additions and 358 deletions.
diff --git a/manifest-beta.json b/manifest-beta.json
@@ -1,7 +1,7 @@
 {
     "id": "pdf-plus",
     "name": "PDF++",
-    "version": "0.38.0-beta3",
+    "version": "0.38.0",
     "minAppVersion": "1.4.16",
     "description": "The most Obsidian-native PDF annotation tool ever.",
     "author": "Ryota Ushio",

diff --git a/manifest.json b/manifest.json
@@ -1,7 +1,7 @@
 {
     "id": "pdf-plus",
     "name": "PDF++",
-    "version": "0.37.16",
+    "version": "0.38.0",
     "minAppVersion": "1.4.16",
     "description": "The most Obsidian-native PDF annotation tool ever.",
     "author": "Ryota Ushio",

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "obsidian-pdf-plus",
-    "version": "0.37.16",
+    "version": "0.38.0",
     "description": "The most Obsidian-native PDF annotation tool ever.",
     "scripts": {
         "dev": "node esbuild.config.mjs",

diff --git a/release b/release
@@ -45,10 +45,13 @@ if __name__ == '__main__':
             exit(1)
 
         manifest['version'] = args.version
+        manifest_beta['version'] = args.version
         package['version'] = args.version
 
         with open('./manifest.json', 'w') as f:
             json.dump(manifest, f, indent=4)
+        with open('./manifest-beta.json', 'w') as f:
+            json.dump(manifest, f, indent=4)
         with open('./package.json', 'w') as f:
             json.dump(package, f, indent=4)
 

diff --git a/src/auto-copy.ts b/src/auto-copy.ts
@@ -0,0 +1,48 @@
+import PDFPlus from 'main';
+import { PDFPlusComponent } from 'lib/component';
+
+
+export class AutoCopyMode extends PDFPlusComponent {
+    iconEl: HTMLElement | null;
+
+    constructor(plugin: PDFPlus) {
+        super(plugin);
+        if (this.settings.autoCopyToggleRibbonIcon) {
+            this.iconEl = plugin.settings.autoCopyToggleRibbonIcon
+                ? plugin.addRibbonIcon(
+                    this.settings.autoCopyIconName,
+                    `${plugin.manifest.name}: Toggle auto-copy`,
+                    () => this.toggle()
+                ) : null;
+        }
+    }
+
+    toggle(enable?: boolean) {
+        enable = enable ?? !this.settings.autoCopy;
+        enable ? this.enable() : this.disable();
+    }
+
+    enable() {
+        this.settings.autoCopy = true;
+        this.load();
+    }
+
+    disable() {
+        this.settings.autoCopy = false;
+        this.unload();
+    }
+
+    onload() {
+        this.lib.registerGlobalDomEvent(this, 'pointerup', () => {
+            if (activeWindow.getSelection()?.toString()) {
+                this.lib.commands.copyLink(false, false);
+            }
+        });
+
+        this.iconEl?.addClass('is-active');
+    }
+
+    onunload() {
+        this.iconEl?.removeClass('is-active');
+    }
+}
diff --git a/src/backlink-visualizer.ts b/src/backlink-visualizer.ts
@@ -123,30 +123,29 @@ export class BacklinkDomManager extends PDFPlusComponent {
     }
 
     hookBacklinkOpeners(el: HTMLElement, cache: PDFBacklinkCache) {
-        const lineNumber = 'position' in cache.refCache ? cache.refCache.position.start.line : undefined;
+        const pos = 'position' in cache.refCache ? cache.refCache.position : undefined;
+        const lineNumber = pos?.start.line;
 
+        const state: any = { isTriggeredFromBacklinkVisualizer: true };
+        if (typeof lineNumber === 'number') {
+            state.scroll = lineNumber;
+        }
         this.registerDomEvent(el, 'mouseover', (event) => {
             this.app.workspace.trigger('hover-link', {
                 event,
                 source: 'pdf-plus',
-                hoverParent: this,
+                hoverParent: this.visualizer,
                 targetEl: el,
                 linktext: cache.sourcePath,
                 sourcePath: this.file.path,
-                state: typeof lineNumber === 'number' ? { scroll: lineNumber } : undefined
+                state
             });
         });
 
         this.registerDomEvent(el, 'dblclick', (event) => {
             if (this.plugin.settings.doubleClickHighlightToOpenBacklink) {
                 const paneType = Keymap.isModEvent(event);
-                if (paneType) {
-                    this.app.workspace.openLinkText(cache.sourcePath, this.file.path, paneType, {
-                        eState: typeof lineNumber === 'number' ? { scroll: lineNumber, line: lineNumber } : undefined
-                    });
-                    return;
-                }
-                this.lib.workspace.openMarkdownLinkFromPDF(cache.sourcePath, this.file.path, lineNumber);
+                this.lib.workspace.openMarkdownLinkFromPDF(cache.sourcePath, this.file.path, paneType, pos ? { pos } : undefined);
             }
         });
     }

diff --git a/src/color-palette.ts b/src/color-palette.ts
@@ -282,6 +282,8 @@ export class ColorPalette extends PDFPlusComponent {
         if (this.cropButtonEl) {
             paletteEl.insertAfter(this.writeFileButtonEl, this.cropButtonEl);
         }
+
+        this.setWriteFile(this.writeFile);
     }
 
     removeWriteFileToggle() {

diff --git a/src/context-menu.ts b/src/context-menu.ts
@@ -632,7 +632,7 @@ export class PDFPlusContextMenu extends Menu {
             this.addItem((item) => {
                 item.setSection('search')
                     .setTitle('Copy link to search')
-                    .setIcon('lucide-copy')
+                    .setIcon('lucide-search')
                     .onClick(() => {
                         lib.copyLink.copyLinkToSearch(false, child, pageNumber, selectedText.trim());
                     });

diff --git a/src/lib/commands.ts b/src/lib/commands.ts
@@ -107,12 +107,16 @@ export class PDFPlusCommands extends PDFPlusLibSubmodule {
                 checkCallback: (checking) => this.setWriteFile(checking, false)
             }, {
                 id: 'toggle-auto-focus',
-                name: 'Toggle auto focus',
+                name: 'Toggle auto-focus',
                 callback: () => this.toggleAutoFocus()
             }, {
-                id: 'toggle-select-to-copy',
-                name: 'Toggle "select text to copy" mode',
-                callback: () => this.plugin.selectToCopyMode.toggle()
+                id: 'toggle-auto-paste',
+                name: 'Toggle auto-paste',
+                callback: () => this.toggleAutoPaste()
+            }, {
+                id: 'toggle-auto-copy',
+                name: 'Toggle auto-copy',
+                callback: () => this.plugin.autoCopyMode.toggle()
             }, {
                 id: 'add-page',
                 name: 'Add new page at the end',
@@ -473,10 +477,11 @@ export class PDFPlusCommands extends PDFPlusLibSubmodule {
     }
 
     toggleAutoFocus() {
-        const iconEl = this.plugin.autoFocusToggleIconEl;
-        iconEl.toggleClass('is-active', !iconEl.hasClass('is-active'));
-        this.settings.autoFocus = iconEl.hasClass('is-active');
-        this.plugin.saveSettings();
+        this.plugin.toggleAutoFocus();
+    }
+
+    toggleAutoPaste() {
+        this.plugin.toggleAutoPaste();
     }
 
     addPage(checking: boolean) {