Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override namespace Observable #trivial #210

Merged
merged 2 commits into from May 7, 2024

Conversation

trmquang93
Copy link
Contributor

this resolve error on Xcode 15, that can not build project

@rxswiftcommunity
Copy link

rxswiftcommunity bot commented Feb 1, 2024

Thanks a lot for contributing @trmquang93! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@trmquang93 trmquang93 changed the title override namespace Observable override namespace Observable #trivial Feb 1, 2024
@JoeMatt JoeMatt self-assigned this Mar 8, 2024
@JoeMatt
Copy link
Contributor

JoeMatt commented May 6, 2024

I haven't seen an error myself.

Could this cause issues with older XCode. I don't know what the RxSwift community guidelines are on something like that, if there are any.

This change looks sound and simple to me but I want to double check it won't give another project problems.

@JoeMatt JoeMatt merged commit 078eb4f into RxSwiftCommunity:main May 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants