Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This fixes all clippy warnings #563

Merged
merged 1 commit into from
Mar 26, 2024
Merged

This fixes all clippy warnings #563

merged 1 commit into from
Mar 26, 2024

Conversation

dvdsk
Copy link
Collaborator

@dvdsk dvdsk commented Mar 26, 2024

Made an issue for missing is_empty(), see:
#562

The DecoderImpl enum triggerd large_enum_variant. There is not an easy fix for that. We could box the VorbisDecoder but at 572 bytes I really do not think thats worth it. Annotated it with an allow

Made an issue for missing `is_empty()`, see:
#562

The DecoderImpl enum triggerd large_enum_variant. There is not an easy
fix for that. We could box the VorbisDecoder but at 572 bytes
I really do not think thats worth it. Annotated it with an allow
@dvdsk
Copy link
Collaborator Author

dvdsk commented Mar 26, 2024

@est31 This is kinda a trivial PR but as I am the author, should this get a review by someone else before I merge it?

And a followup which of the RustAudio members could ask for a review in general (not the monster that is #513 ill take care of that with a fellow engineer, but for example PR #559).

@est31
Copy link
Member

est31 commented Mar 26, 2024

as I am the author, should this get a review by someone else before I merge it?

yeah if it's trivial and feels non-controversial it's fine to merge it without review.

And a followup which of the RustAudio members could ask for a review in general

Tough question. I'm generally available as a reviewer, otherwise I don't really know. Maybe we should make a call for maintainers? rodio should not die because of maintainer bottleneck :).

@dvdsk dvdsk merged commit e0b8e9b into master Mar 26, 2024
10 checks passed
@dvdsk
Copy link
Collaborator Author

dvdsk commented Mar 26, 2024

Tough question. I'm generally available as a reviewer, otherwise I don't really know. Maybe we should make a call for maintainers? rodio should not die because of maintainer bottleneck :).

I have been working through the recent issues and most reporters are quite willing to work on a PR so there is a clear need for Rodio. I am in favor of looking for more maintainers, however I have no idea on how to do so safely. Rodio is a popular dependency, any mistake (or malicious intent) could have a wide impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants