Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Sink::empty #562

Open
dvdsk opened this issue Mar 26, 2024 · 1 comment
Open

Rename Sink::empty #562

dvdsk opened this issue Mar 26, 2024 · 1 comment
Labels
breaking Proposed change that would break the public API enhancement

Comments

@dvdsk
Copy link
Collaborator

dvdsk commented Mar 26, 2024

It should probably be called is_empty. Clippy even flags on it.

Changing it would break a lot of code though...
Could deprecate it first?

Let me hear you thoughts, for now I am letting clippy now to ignore it.
@dvdsk dvdsk added breaking Proposed change that would break the public API enhancement labels Mar 26, 2024
@dvdsk
Copy link
Collaborator Author

dvdsk commented Mar 26, 2024

same is true for SpatialSink::empty

dvdsk added a commit that referenced this issue Mar 26, 2024
@dvdsk
This fixes all clippy warnings
77ca23a 
Made an issue for missing `is_empty()`, see:
#562

The DecoderImpl enum triggerd large_enum_variant. There is not an easy
fix for that. We could box the VorbisDecoder but at 572 bytes
I really do not think thats worth it. Annotated it with an allow
@dvdsk dvdsk mentioned this issue Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Proposed change that would break the public API enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dvdsk